Repository navigation
fix: hasBothRollupOptionsAndRolldownOptions should return false for proxy case - #22043
Merged
Merged
Conversation
…proxy case When mergeConfig sets up rollupOptions to rolldownOptions proxy, both properties exist but point to the same object. The function hasBothRollupOptionsAndRolldownOptions should return false in this case to avoid false positive warnings about both options being set. Fixes vitejs#22040
hasBothRollupOptionsAndRolldownOptions should return false for proxy case
sapphi-red
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When mergeConfig is called with only rollupOptions, the function setupRollupOptionCompat creates a proxy where rollupOptions points to rolldownOptions. Both properties exist but they reference the same object.
The function hasBothRollupOptionsAndRolldownOptions was incorrectly returning true in this case, causing false positive warnings.
This fix adds a check to ensure both properties are actually different objects before returning true.
Related Issue
refs #22040