test: respect commonjs options in playgrounds#13273
Merged
Conversation
|
|
4 tasks
sapphi-red
approved these changes
May 21, 2023
Member
sapphi-red
left a comment
There was a problem hiding this comment.
To make the external playground work with build dep-optimization, it seems we need to add a option to declare whether an external dependency is CJS or ESM.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Member
Author
|
I wonder if we could tell people to continue using the commonjs plugin for these deps in that case, so we try to avoid this cjs compat features if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid forcing deps optimization for playgrounds that define custom
commonjsOptions. When runningpnpm run test-build-without-plugin-commonjs, this test:playground/external/__tests__/external.spec.tswas failing and is working now after the PR.Note: in case you run the tests, we have another test in main failing with this env flag in
playground/ssr-resolvethat is unrelated to this issue.What is the purpose of this pull request?