Skip to content

Commit 1958eeb

Browse files
authored
fix(dev): disable extglobs for consistency (#21745)
1 parent 8546520 commit 1958eeb

3 files changed

Lines changed: 8 additions & 10 deletions

File tree

packages/vite/src/node/plugins/importMetaGlob.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,7 @@ export async function transformGlobImport(
448448
dot: !!options.exhaustive,
449449
expandDirectories: false,
450450
ignore: options.exhaustive ? [] : ['**/node_modules/**'],
451+
extglob: false,
451452
})
452453
)
453454
.filter((file) => file !== id)

playground/glob-import/__tests__/glob-import.spec.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,12 @@ const baseRawResult = {
8888
}
8989

9090
test('should work', async () => {
91-
// TODO: extglobs are not supported yet: https://github.com/vitejs/rolldown-vite/issues/365
92-
if (process.env._VITE_TEST_JS_PLUGIN) {
93-
await expect
94-
.poll(async () => JSON.parse(await page.textContent('.result')))
95-
.toStrictEqual(allResult)
96-
await expect
97-
.poll(async () => JSON.parse(await page.textContent('.result-eager')))
98-
.toStrictEqual(allResult)
99-
}
91+
await expect
92+
.poll(async () => JSON.parse(await page.textContent('.result')))
93+
.toStrictEqual(allResult)
94+
await expect
95+
.poll(async () => JSON.parse(await page.textContent('.result-eager')))
96+
.toStrictEqual(allResult)
10097
await expect
10198
.poll(async () =>
10299
JSON.parse(await page.textContent('.result-node_modules')),

playground/glob-import/dir/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const modules = import.meta.glob('./*.(js|ts)', { eager: true })
1+
const modules = import.meta.glob('./*.{js,ts}', { eager: true })
22
const globWithAlias = import.meta.glob('@dir/al*.js', { eager: true })
33

44
// test negative glob

0 commit comments

Comments
 (0)