fix: Improve create-turbo connectivity check and offline error messages#12257
Merged
anthonyshew merged 1 commit intomainfrom Mar 12, 2026
Merged
fix: Improve create-turbo connectivity check and offline error messages#12257anthonyshew merged 1 commit intomainfrom
anthonyshew merged 1 commit intomainfrom
Conversation
Check github.com instead of registry.yarnpkg.com since templates are downloaded from GitHub. Return diagnostic reasons on failure so users can understand why the check failed (DNS timeout vs error, proxy status). Also detect HTTPS_PROXY (uppercase) environment variable.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions Bot
added a commit
that referenced
this pull request
Mar 12, 2026
## Release v2.8.17-canary.7 Versioned docs: https://v2-8-17-canary-7.turborepo.dev ### Changes - ci: Add Node.js 24 to JS test matrices (#12256) (`12baf0d`) - release(turborepo): 2.8.17-canary.6 (#12258) (`bcad89d`) - fix: Improve create-turbo connectivity check and offline error messages (#12257) (`0298dac`) Co-authored-by: Turbobot <turbobot@vercel.com>
anthonyshew
added a commit
that referenced
this pull request
Mar 13, 2026
## Summary Closes #12250 - Remove the `isOnline()` preflight connectivity check from `create-turbo` - Remove the `proxy-agent` dependency (only used by the removed check) ## Why The `isOnline` check was [introduced in #11297](#11297) with a 5-second timeout. For users with slow routes to `github.com` (but otherwise working internet), this causes a false "You appear to be offline" error that blocks `create-turbo` entirely. Two prior fixes ([#12257](#12257), [#12277](#12277)) changed the check target and method but kept the 5s timeout. The [reporter still fails with canary.14](#12250 (comment)) across all package managers. The check is redundant. `createProject` already handles offline failures through `retry({ retries: 3 })` and throws `DownloadError`, which `handleErrors` catches with a clear message ("Unable to download template from GitHub" + the specific error). There's no need for a separate preflight gate. ## Testing All existing `create-turbo` tests pass. The "throws correct error message when a download error is encountered" test verifies the `DownloadError` path works correctly without the preflight check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.cominstead ofregistry.yarnpkg.com—create-turbodownloads templates from GitHub, not the Yarn registry. The CNAME chain forregistry.yarnpkg.comcan exceed the 5s DNS timeout on slower resolvers, causing false "offline" reports.HTTPS_PROXY(uppercase) in addition tohttps_proxy.Closes #12250
Improve error messaging.
When the check fails, users now see specific diagnostics: