fix: Add allowComments and allowTrailingCommas to turbo.json schema#11579
Merged
anthonyshew merged 2 commits intovercel:mainfrom Jan 31, 2026
Merged
Conversation
This fixes VSCode warnings about trailing commas in turbo.jsonc files when formatted with tools like oxfmt that add trailing commas to JSONC. Fixes vercel#11566 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
@ddmoney420 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
anthonyshew
suggested changes
Jan 30, 2026
Contributor
anthonyshew
left a comment
There was a problem hiding this comment.
Please see the bot comment!
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
The Rust schema generator now adds these JSONC properties so CI regeneration won't overwrite manually-added entries.
8d30f36 to
cf34ec9
Compare
allowComments and allowTrailingCommas to turbo.json schema
anthonyshew
approved these changes
Jan 31, 2026
Contributor
anthonyshew
left a comment
There was a problem hiding this comment.
I went ahead and fixed this up. Thanks for getting things moving here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
allowCommentsandallowTrailingCommasproperties to the turbo.json schema to prevent VSCode warnings when using JSONC features.Fixes #11566
Problem
When formatting
turbo.jsoncwith tools likeoxfmtorprettierthat add trailing commas, VSCode shows warnings like "Trailing comma jsonc(519)" because the schema doesn't declare support for JSONC features.Solution
Added two lines to
packages/turbo-types/schemas/schema.json:Test plan
turbo.jsoncfile with trailing commas in VSCode🤖 Generated with Claude Code