Skip to content

fix: Support trailing commas in microfrontends JSONC files#11573

Merged
anthonyshew merged 6 commits intomainfrom
fix/microfrontends-trailing-commas
Jan 28, 2026
Merged

fix: Support trailing commas in microfrontends JSONC files#11573
anthonyshew merged 6 commits intomainfrom
fix/microfrontends-trailing-commas

Conversation

@anthonyshew
Copy link
Copy Markdown
Contributor

@anthonyshew anthonyshew commented Jan 28, 2026

Summary

  • Enables trailing comma support in the microfrontends config parser
  • JSONC files commonly use trailing commas (editors/formatters add them), but turbo was rejecting them

Test Plan

  • Added trailing-commas.jsonc fixture with comments and trailing commas
  • Added tests verifying trailing commas are accepted in both configv1.rs and schema.rs
  • Verified fix works end-to-end with a real-world microfrontends config

CLOSES TURBO-5129

@anthonyshew anthonyshew requested a review from a team as a code owner January 28, 2026 20:05
@anthonyshew anthonyshew requested review from tknickman and removed request for a team January 28, 2026 20:05
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
examples-basic-web Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
examples-designsystem-docs Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
examples-gatsby-web Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
examples-kitchensink-blog Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
examples-nonmonorepo Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
examples-svelte-web Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
examples-tailwind-web Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
examples-vite-web Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
turbo-site Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm
turborepo-test-coverage Ready Ready Preview, Comment, Open in v0 Jan 28, 2026 8:09pm

Comment thread crates/turborepo-microfrontends/src/schema.rs Outdated
Comment thread crates/turborepo-microfrontends/src/schema.rs Outdated
Comment thread crates/turborepo-microfrontends/fixtures/trailing-commas.jsonc Outdated
Comment thread crates/turborepo-microfrontends/fixtures/trailing-commas.jsonc Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 28, 2026

Congrats! CodSpeed is installed 🎉

🆕 4 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks


Open in CodSpeed

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Metric Coverage
Lines 75.90%
Functions 46.77%
Branches 0.00%

View full report

@anthonyshew anthonyshew merged commit 30c381d into main Jan 28, 2026
107 checks passed
@anthonyshew anthonyshew deleted the fix/microfrontends-trailing-commas branch January 28, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants