feat: add ability to add text stroke #645
Merged
shuding merged 6 commits intovercel:mainfrom Nov 19, 2024
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shuding
reviewed
Nov 3, 2024
Member
shuding
left a comment
There was a problem hiding this comment.
Looks great, thank you! We need some tests though (check out /tests).
de02436 to
37e40ee
Compare
Contributor
Author
|
Sorry for the sudden change. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding ability to stroke to texts.
fixes: #578
Added 2 properties (
WebkitTextStrokeWidth,WebkitTextStrokeColor) and 1 shorthands (WebkitTextStroke). When stroke is enabled,paint-order: stroke;andstroke-linejoin: round;are automatically set to prevent the stroke from obscuring the text.I don't have a deep understanding of all the code so further improvements may be needed.