Skip to content

[turbopack] Respect {eval:true} in worker_threads constructors#91666

Merged
lukesandberg merged 2 commits intocanaryfrom
dynamic_worker_threads_in_pdfjs
Mar 19, 2026
Merged

[turbopack] Respect {eval:true} in worker_threads constructors#91666
lukesandberg merged 2 commits intocanaryfrom
dynamic_worker_threads_in_pdfjs

Conversation

@lukesandberg
Copy link
Copy Markdown
Contributor

@lukesandberg lukesandberg commented Mar 19, 2026

What?

Fixed Turbopack incorrectly trying to resolve inline JavaScript code as module references when new Worker() is called with { eval: true } option.

Now we skip creating a reference when eval:true, and report warnings if we cannot tell what the value is

Why?

Libraries like jsPDF create Worker threads by passing inline JavaScript code as the first argument along with { eval: true } as the second argument. Turbopack was incorrectly treating this inline code as a file path and attempting to resolve it as a module reference, causing build failures.

How?

Added logic to detect when the eval: true option is passed to the Worker constructor. When this option is present, Turbopack now skips creating a worker reference since the first argument contains executable code rather than a file path. Added comprehensive test coverage using jsPDF to verify the fix works correctly.

Fixes #91642

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lukesandberg lukesandberg changed the title Fix #91642 [turbopack] Respect {eval:true} in nodejs worker_threads constructors Mar 19, 2026
@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js. labels Mar 19, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 19, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing dynamic_worker_threads_in_pdfjs (6c2647a) with canary (afbce6a)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread turbopack/crates/turbopack-ecmascript/src/references/mod.rs Outdated
@lukesandberg lukesandberg changed the title [turbopack] Respect {eval:true} in nodejs worker_threads constructors [turbopack] Respect {eval:true} in worker_threads constructors Mar 19, 2026
@nextjs-bot
Copy link
Copy Markdown
Contributor

nextjs-bot commented Mar 19, 2026

Stats from current PR

🟢 1 improvement

Metric Canary PR Change Trend
node_modules Size 484 MB 483 MB 🟢 326 kB (0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁▅▁
Cold (Ready in log) 438ms 439ms ▁▁▁▅▁
Cold (First Request) 1.143s 1.122s ▁▁▂▄▁
Warm (Listen) 457ms 457ms ▁▁▁▅▁
Warm (Ready in log) 448ms 444ms ▁▁▁▆▁
Warm (First Request) 344ms 338ms ▁▁▁▃▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ▁▁▁▁▁
Cold (Ready in log) 436ms 436ms ▁▁▁▁▁
Cold (First Request) 1.851s 1.870s ▁▂▁▁▃
Warm (Listen) 455ms 456ms ▁▁▁▁▁
Warm (Ready in log) 436ms 435ms ▁▁▁▁▁
Warm (First Request) 1.872s 1.866s ▁▂▁▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.790s 3.792s ▂▁▁▅▁
Cached Build 3.771s 3.776s ▂▁▁▅▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.279s 14.320s ▁▁▁▁▁
Cached Build 14.448s 14.472s ▁▁▁▁▁
node_modules Size 484 MB 483 MB 🟢 326 kB (0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
0-a3rz67ec0it.js gzip 157 B N/A -
0.9zdz7ux63kn.js gzip 48.7 kB N/A -
0~lwfcrlb4v_9.css gzip 115 B 115 B
00h0nz7r436~l.js gzip 13.3 kB N/A -
00ivb_iunbucu.js gzip 13 kB N/A -
02ku7edzc_wf7.js gzip 450 B N/A -
03~yq9q893hmn.js gzip 39.4 kB 39.4 kB
037mxw~u2_79t.js gzip 154 B N/A -
08wow2p6zxy.b.js gzip 7.61 kB N/A -
092lcb3fqrrf9.js gzip 8.52 kB N/A -
0aj~xs1l1g8tg.js gzip 8.53 kB N/A -
0gob4q88vgv3u.js gzip 156 B N/A -
0h35gmp9u328z.js gzip 8.54 kB N/A -
0h6fkavebp.iz.js gzip 8.47 kB N/A -
0hcg0snee_9wv.js gzip 156 B N/A -
0i8jiw50w3l38.js gzip 154 B N/A -
0ino_yf1k3h6k.js gzip 10.4 kB N/A -
0kkeoe2n.293z.js gzip 160 B N/A -
0l~j-k_rjuult.js gzip 70.8 kB N/A -
0mc16gv2x1bet.js gzip 13.7 kB N/A -
0mcszt6vwd60_.js gzip 154 B N/A -
0mgzv7x.0y719.js gzip 169 B N/A -
0moy~uao4dl.m.js gzip 9.19 kB N/A -
0n5ln2l5jgra~.js gzip 152 B N/A -
0ovzdapbcjgc7.js gzip 65.7 kB N/A -
0p2fwrxw124by.js gzip 160 B N/A -
0q50rtpusjy90.js gzip 2.28 kB N/A -
0smgy2grrrlka.js gzip 8.58 kB N/A -
0t1dzhdfh0txh.js gzip 215 B 215 B
0vt7pofxnk8in.js gzip 10.1 kB N/A -
0zid7o0-vupvp.js gzip 225 B N/A -
1030wmumq.hbq.js gzip 156 B N/A -
11yo3xfd6b147.js gzip 12.9 kB N/A -
13.84hqxl_1p7.js gzip 9.76 kB N/A -
13ddjl2tc8beg.js gzip 153 B N/A -
1554wr-t7p6z-.js gzip 8.55 kB N/A -
15pd.z8aymtma.js gzip 155 B N/A -
15tjst79~qy3_.js gzip 1.46 kB N/A -
15z_v00ne4ud0.js gzip 8.47 kB N/A -
17d_m3p4j9w6r.js gzip 5.62 kB N/A -
17yu~3yiu7d2m.js gzip 8.52 kB N/A -
turbopack-0-..rr~~.js gzip 4.15 kB N/A -
turbopack-01..zoj7.js gzip 4.16 kB N/A -
turbopack-01..cl9..js gzip 4.16 kB N/A -
turbopack-02..bqca.js gzip 4.14 kB N/A -
turbopack-0d..r9ub.js gzip 4.15 kB N/A -
turbopack-0f..1w4v.js gzip 4.15 kB N/A -
turbopack-0g..5lrl.js gzip 4.16 kB N/A -
turbopack-0l..aco3.js gzip 4.16 kB N/A -
turbopack-0p..4qy0.js gzip 4.17 kB N/A -
turbopack-0p..y0cg.js gzip 4.16 kB N/A -
turbopack-0q..cwm4.js gzip 4.15 kB N/A -
turbopack-0z..uyvd.js gzip 4.16 kB N/A -
turbopack-10..ov9~.js gzip 4.16 kB N/A -
turbopack-15..lg62.js gzip 4.16 kB N/A -
0_.49f9yku.5j.js gzip N/A 48.6 kB -
0~qj4.emn9-a4.js gzip N/A 157 B -
03t__~.5lvgeu.js gzip N/A 5.62 kB -
04d6ll75jqx3r.js gzip N/A 9.19 kB -
0583exyh-yhc7.js gzip N/A 9.76 kB -
072lv63r8dcz~.js gzip N/A 8.58 kB -
075t9dxgbf0m8.js gzip N/A 13.7 kB -
0ar1~bwpezfgw.js gzip N/A 13.3 kB -
0c99mq1ez2bke.js gzip N/A 450 B -
0cq-cmde_ws6u.js gzip N/A 8.47 kB -
0fmer2v8q.v.js gzip N/A 156 B -
0fwf102w10o9~.js gzip N/A 8.52 kB -
0fy~a88g10-jf.js gzip N/A 154 B -
0g6ifg-gvy4t2.js gzip N/A 157 B -
0gtmn.q_j1v5r.js gzip N/A 10.4 kB -
0h28oyqdt8p.t.js gzip N/A 157 B -
0h5~v-tahitcf.js gzip N/A 10.1 kB -
0h8temrq-5.-u.js gzip N/A 155 B -
0nclq9z6yzzm5.js gzip N/A 1.46 kB -
0nzumcogektg7.js gzip N/A 8.55 kB -
0p88ggrxiy7bp.js gzip N/A 7.6 kB -
0s.c-cn5eebrx.js gzip N/A 8.47 kB -
0stac1-ouh7a3.js gzip N/A 154 B -
0tna7lg6q4zne.js gzip N/A 12.9 kB -
0votdfxr5fb5u.js gzip N/A 2.28 kB -
0vuyhp23e90.js gzip N/A 168 B -
0yafg5j4p_ovz.js gzip N/A 163 B -
0ykl9bs_qj.5..js gzip N/A 8.52 kB -
0z6oisth0l_k5.js gzip N/A 157 B -
0za~ufkq3c6-2.js gzip N/A 161 B -
0zfen0tnxp4gh.js gzip N/A 8.55 kB -
10wkq1h9jzkg..js gzip N/A 225 B -
12wznjrfz4cnj.js gzip N/A 70.8 kB -
149ndfh8zfcaz.js gzip N/A 8.53 kB -
15gkb_10omqgr.js gzip N/A 13 kB -
15xdtbdz4m8mm.js gzip N/A 65.7 kB -
173uityozy_~p.js gzip N/A 156 B -
17iim96v43ctz.js gzip N/A 151 B -
turbopack-0_..2vmd.js gzip N/A 4.16 kB -
turbopack-02..cm0b.js gzip N/A 4.17 kB -
turbopack-0e..~usu.js gzip N/A 4.16 kB -
turbopack-0i..xsor.js gzip N/A 4.16 kB -
turbopack-0i..3k-s.js gzip N/A 4.16 kB -
turbopack-0i.._bqp.js gzip N/A 4.16 kB -
turbopack-0p..8w95.js gzip N/A 4.16 kB -
turbopack-0q..r~im.js gzip N/A 4.16 kB -
turbopack-13.._u53.js gzip N/A 4.16 kB -
turbopack-15..6_1g.js gzip N/A 4.16 kB -
turbopack-16..itl..js gzip N/A 4.14 kB -
turbopack-16..gkyt.js gzip N/A 4.16 kB -
turbopack-16..q3h..js gzip N/A 4.16 kB -
turbopack-18..h.-5.js gzip N/A 4.16 kB -
Total 463 kB 463 kB ✅ -139 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 711 B 715 B
Total 711 B 715 B ⚠️ +4 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 433 B 426 B 🟢 7 B (-2%)
Total 433 B 426 B ✅ -7 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 60.4 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.7 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 255 B 254 B
main-HASH.js gzip 39.3 kB 39.2 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.7 kB -
9544-HASH.js gzip N/A 61.1 kB -
Total 234 kB 235 kB ⚠️ +629 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.51 kB 2.51 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 269 kB 268 kB
Total 394 kB 393 kB ✅ -668 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 618 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 43.9 kB 43.9 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 45.5 kB 45.5 kB ✅ -10 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.29 MB 4.27 MB 🟢 21.4 kB (0%)
index.pack gzip 110 kB 110 kB
index.pack.old gzip 110 kB 110 kB
Total 4.51 MB 4.49 MB ✅ -22.1 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 333 kB 333 kB
app-page-exp..prod.js gzip 181 kB 181 kB
app-page-tur...dev.js gzip 333 kB 333 kB
app-page-tur..prod.js gzip 181 kB 181 kB
app-page-tur...dev.js gzip 330 kB 329 kB
app-page-tur..prod.js gzip 179 kB 179 kB
app-page.run...dev.js gzip 330 kB 330 kB
app-page.run..prod.js gzip 179 kB 179 kB
app-route-ex...dev.js gzip 76.1 kB 76 kB
app-route-ex..prod.js gzip 51.8 kB 51.7 kB
app-route-tu...dev.js gzip 76.1 kB 76 kB
app-route-tu..prod.js gzip 51.8 kB 51.7 kB
app-route-tu...dev.js gzip 75.7 kB 75.6 kB
app-route-tu..prod.js gzip 51.6 kB 51.5 kB
app-route.ru...dev.js gzip 75.7 kB 75.6 kB
app-route.ru..prod.js gzip 51.5 kB 51.5 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.4 kB 43.4 kB
pages-api-tu..prod.js gzip 33 kB 33 kB
pages-api.ru...dev.js gzip 43.3 kB 43.3 kB
pages-api.ru..prod.js gzip 33 kB 33 kB
pages-turbo....dev.js gzip 52.7 kB 52.7 kB
pages-turbo...prod.js gzip 38.6 kB 38.6 kB
pages.runtim...dev.js gzip 52.7 kB 52.7 kB
pages.runtim..prod.js gzip 38.6 kB 38.6 kB
server.runti..prod.js gzip 62.5 kB 62.4 kB
Total 2.96 MB 2.95 MB ✅ -2.56 kB
📝 Changed Files (25 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • server.runtime.prod.js
  • pages-api-tu..ntime.dev.js
  • pages-api-tu..time.prod.js
  • pages-api.runtime.dev.js
  • ... and 5 more
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js
failed to diff
app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

pages-api-tu..ntime.dev.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-api.runtime.dev.js

Diff too large to display

pages-api.ru..time.prod.js

Diff too large to display

pages-turbo...ntime.dev.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/6c2647aac0bae46f0e13ce78da99c01eddc9e073/next

@nextjs-bot
Copy link
Copy Markdown
Contributor

nextjs-bot commented Mar 19, 2026

Tests Passed

respect the  flag to node js Worker threads
@lukesandberg lukesandberg force-pushed the dynamic_worker_threads_in_pdfjs branch from 36437ad to 4b37578 Compare March 19, 2026 19:05
@lukesandberg lukesandberg marked this pull request as ready for review March 19, 2026 19:07
@lukesandberg lukesandberg requested a review from mischnic March 19, 2026 19:08
@lukesandberg lukesandberg merged commit 3003e17 into canary Mar 19, 2026
291 of 295 checks passed
Copy link
Copy Markdown
Contributor Author

Merge activity

@lukesandberg lukesandberg deleted the dynamic_worker_threads_in_pdfjs branch March 19, 2026 20:58
ijjk pushed a commit that referenced this pull request Mar 20, 2026
)

### What?

Fixed Turbopack incorrectly trying to resolve inline JavaScript code as module references when `new Worker()` is called with `{ eval: true }` option.

Now we skip creating a reference when `eval:true`, and report warnings if we cannot tell what the value is

### Why?

Libraries like jsPDF create Worker threads by passing inline JavaScript code as the first argument along with `{ eval: true }` as the second argument. Turbopack was incorrectly treating this inline code as a file path and attempting to resolve it as a module reference, causing build failures.

### How?

Added logic to detect when the `eval: true` option is passed to the Worker constructor. When this option is present, Turbopack now skips creating a worker reference since the first argument contains executable code rather than a file path. Added comprehensive test coverage using jsPDF to verify the fix works correctly.

Fixes #91642
swve added a commit to learnhouse/learnhouse that referenced this pull request Mar 23, 2026
Next.js 16.2.0 introduced a Turbopack regression where dynamic
Worker constructors with { eval: true } (used by fflate, a jspdf
dependency) fail with "Module not found: Can't resolve <dynamic>".
This was fixed upstream in vercel/next.js#91666, shipped in 16.2.1.
@github-actions github-actions Bot added the locked label Apr 3, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failing after 16.1.2 to 16.2 upgrade

3 participants