fix: sourcemap sources removes webpack path#1122
Merged
styfle merged 4 commits intovercel:mainfrom Oct 18, 2023
axuj:main
Merged
fix: sourcemap sources removes webpack path#1122styfle merged 4 commits intovercel:mainfrom axuj:main
styfle merged 4 commits intovercel:mainfrom
axuj:main
Conversation
styfle
reviewed
Oct 12, 2023
| if (source.startsWith('webpack/')) | ||
| return '/webpack/' + source.slice(8); | ||
| return sourceMapBasePrefix + source; | ||
| // webpack://[namespace]/[resourcePath] |
Contributor
There was a problem hiding this comment.
Looks like this no longer accounts for the webpack:///webpack:/// case.
Contributor
Author
There was a problem hiding this comment.
Yes, look at output.devtoolModuleFilenameTemplate , I think using webpack config is a better choice
Contributor
There was a problem hiding this comment.
Thanks! Is there a way to add a test to confirm this fixes the issue?
Contributor
Author
There was a problem hiding this comment.
Sure! I've added tests
test/unit/minify update output
test/unit/minify-sourcemap-register test/unit/minify-v8cache-sourcemap-register
|
🎉 This PR is included in version 0.38.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source is now in the format
webpack://[namespace]/[resourcePath]