chore: upgrade TypeScript and fixup types#927
Merged
Conversation
Member
|
Related to #856 |
broofa
requested changes
Mar 16, 2026
Member
There was a problem hiding this comment.
[Trying out using copilot to fix some of these issues. Not sure how that's going to work out, but we'll figure it out.] Nevermind. Copilot doesn't work on x-repository requests.
Thanks for the contribution. The NonSharedArrayBuffer type seems like a nice solution to the TS version problem, but something here broke the npm run test:node tests. Those will need to get fixed.
Contributor
Author
|
Oh sorry requested re-review before I fixed the tests, I'll look at that now |
Contributor
Author
|
Okay should all be fixed now |
broofa
requested changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to make use of
uuid.parse()but the return type wasUint8Arrayinstead of theUint8Array<ArrayBuffer>type thatUint8Array.of()actually returns.In order to keep it compatible with different versions of TypeScript'd definitions I've used:
Which then should be the correct type no matter what version of TypeScript someone is on
I also upgraded the version of TypeScript to double check that nothing would break, and I just had to fix one small type in
v35()