Repository navigation
Clamp ProgressBar completion to the drawable range - #1388
Merged
Merged
Conversation
ProgressBar raised or drew the wrong bar when current or done was out of range or not finite: - done <= 0 or NaN, and a NaN ratio, now render an empty bar. - current is clamped to [0, done], including infinite values, so a negative current no longer draws a part-filled bar or raises IndexError when satt is set. - An operand too large for a float draws a full bar when current exceeds done, and an empty one otherwise. - get_text() and render() share the clamped computation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProgressBar raised or drew the wrong bar when current or done was out of range or not finite:
Checklist
masterbranchtoxsuccessfully in local environment