Skip to content

[1.26] Fix running CPython 2.7 tests in CI#3137

Merged
illia-v merged 9 commits intourllib3:1.26.xfrom
illia-v:python2.7-ci
Nov 15, 2023
Merged

[1.26] Fix running CPython 2.7 tests in CI#3137
illia-v merged 9 commits intourllib3:1.26.xfrom
illia-v:python2.7-ci

Conversation

@illia-v
Copy link
Copy Markdown
Member

@illia-v illia-v commented Oct 2, 2023

Fixes #3077

actions/setup-python dropped support for CPython 2.7.
Since we still need to run tests using the version, CI starts to use Ubuntu's CPython 2.7 version.
Unfortunately, testing using CPython 2.7 on macOS and Windows is dropped by this PR.

This PR is based on #3136 to display the tests passing.

@sethmlarson
Copy link
Copy Markdown
Member

Let's test all the changes we implemented to 1.26.x against this Python 2.7 install, thanks @illia-v!

@illia-v
Copy link
Copy Markdown
Member Author

illia-v commented Oct 17, 2023

The coverage problem in Ubuntu 22.04 is related to not reaching this warning because Ubuntu disabled TLS 1.0 & 1.1.

I am not sure what's the problem with the two tests related to IP versions in Ubuntu 20.04, but it looks like fixing them won't fix the coverage issue because Ubuntu 20.04 disables TLS 1.0 & 1.1 too (there is SKIPPED [84] /home/runner/work/urllib3/urllib3/test/conftest.py:264: Test requires TLSv1.1 in the log.)

I tried possible fixes like using Python 2.7 in a container in CI or tweaking OpenSSL config files, but it didn't work and I cannot invest more time in this for now. What do you think about ignoring the coverage miss for now to have tests passing?

@sethmlarson
Copy link
Copy Markdown
Member

@illia-v Let's ignore the coverage miss for the 1.26.x branch and get this merged if that's all that's needed.

@illia-v illia-v merged commit 7e2d389 into urllib3:1.26.x Nov 15, 2023
@illia-v illia-v deleted the python2.7-ci branch November 15, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants