fix(ujson.loads): raises a JSONDecodeError instead of SystemError when parsing a nested json string#667
Merged
bwoodsend merged 4 commits intoultrajson:mainfrom May 9, 2025
Merged
Conversation
…n parsing a nested json string
Member
|
Thanks for the PR, please could you add tests that check that the exception raised is a https://docs.python.org/3/library/json.html#json.JSONDecodeError |
Contributor
Author
|
@hugovk Hi, I've added the tests. |
for more information, see https://pre-commit.ci
Collaborator
|
We'll need to be really careful that we're clearing up objects properly. Every time we've done anything error catching related, we've ended up with memory leaks. |
Collaborator
|
I've given it a shot locally. I don't see any signs of a leak. |
bwoodsend
approved these changes
May 7, 2025
Collaborator
|
Shall we hit the release button? We've got this and Windows ARM64 in the queue. |
Member
|
Let's wait a few days, cibuildwheel should have 3.14 beta support soon: pypa/cibuildwheel#2047 (comment) In the meantime, here's a PR to test 3.14: #668 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #656
Changes proposed in this pull request: