Merged
Conversation
for more information, see https://pre-commit.ci
Collaborator
|
Is there anything we get out of doing this? To me, it just means more traversal every time I want to open a file. It's also going to be a lot of faff for all the repackagers out there. |
Member
Author
|
It's a first step to migrating the build config from We'd get an error with the current layout: It lists two other options, however |
Collaborator
|
I personally prefer the [tool.setuptools.packages.find]
include = ["xxx"]approach but I'm not that fussed. |
Collaborator
|
Does it make a difference to your |
Member
Author
|
I've not used |
Collaborator
|
Up to you then. |
bwoodsend
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than building with
python/,lib/anddep/in the root, move them tosrc/ujson/.