Build aarch64 wheels using native runners#652
Merged
hugovk merged 2 commits intoultrajson:mainfrom Jan 18, 2025
Merged
Conversation
PyPy builds will be disabled by default in version 3. Enabling PyPy builds should be specified by enable
Collaborator
|
Huh, I had it in my head that we were building for more than just aarch64. But looking at the PyPI statistics, the next most popular targets are s390x at 263/month and armv7l at 259/month (the latter we can't even put on PyPI anyway) so I suppose that ignoring them is justified. |
bwoodsend
approved these changes
Jan 18, 2025
Member
Author
|
We are testing for some more architectures: ultrajson/.github/workflows/test.yml Line 70 in ea1b20b Perhaps we could replace some QEMU from that workflow too? |
Collaborator
|
If you think the 2 x ~90 seconds is worth the faff then sure. 🙂 Since there's not much PR traffic around here, there's not much to be gained from workflow optimisation. |
Member
Author
|
Yeah, let's leave that one be. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions now has free hosted Arm runners:
https://github.blog/news-insights/product-news/arm64-on-github-actions-powering-faster-more-efficient-build-systems/
That means we can replace the slow QEMU jobs with native
ubuntu-24.04-armto build theaarch64wheels in a single job.Also fix a warning by adding
pypytoCIBW_ENABLE: