Pin setuptools < 72.2 to fix build on PyPy#638
Merged
hugovk merged 2 commits intoultrajson:mainfrom Sep 2, 2024
Merged
Conversation
Member
Author
|
Member
Author
|
pypa/setuptools#4621 is a possible duplicate of pypa/distutils#283. Could also be upper-pinned just for PyPy, like https://github.com/cvc5/cvc5/pull/11181/files. |
Collaborator
|
I think I'd prefer that. IMO, we should limit the forcing of a stale version on users as much as we can get away with. |
Member
Author
|
Updated! |
bwoodsend
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#637 failed for PyPy on Ubuntu and macOS (but not Windows):
https://github.com/ultrajson/ultrajson/actions/runs/10650149917/job/29521178562?pr=637
Our last passing build was on 1st August: #636 (these regular dependabot PRs are useful after all!)
It looks like a setuptools thing. I tried setuptools 72.1, the current on 1st August, which worked, and found the first failure happened with 72.2, released on 2nd August.
https://setuptools.pypa.io/en/stable/history.html#v72-2-0
setuptools 72.2 had changes related to distutils and compilers, which tracks with the traceback above:
I'll report this to setuptools.
And let's pin an upper setuptools version for the build backend for now.