Skip to content

Further updates to nullaway-bom POM properties#1384

Merged
msridhar merged 1 commit intomasterfrom
bom-packaging
Dec 19, 2025
Merged

Further updates to nullaway-bom POM properties#1384
msridhar merged 1 commit intomasterfrom
bom-packaging

Conversation

@msridhar
Copy link
Copy Markdown
Collaborator

@msridhar msridhar commented Dec 19, 2025 •
edited by coderabbitai Bot
Loading

  • Set packaging to pom instead of jar
  • Set a better name and description

Tested locally and the generated POM better matches what AssertJ does.

Summary by CodeRabbit

  • Chores
    • Updated NullAway Bill of Materials package metadata and configuration, including naming and packaging format, to properly identify and document its purpose for managing multiple NullAway artifacts.

✏️ Tip: You can customize this high-level summary in your review settings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.35%. Comparing base (6a29dce) to head (d46dcc9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1384   +/-   ##
=========================================
  Coverage     88.35%   88.35%           
  Complexity     2642     2642           
=========================================
  Files            97       97           
  Lines          8888     8888           
  Branches       1775     1775           
=========================================
  Hits           7853     7853           
  Misses          518      518           
  Partials        517      517

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 19, 2025

Walkthrough

This change updates the Gradle properties for the nullaway-bom module to properly configure it as a Bill of Materials artifact. The POM name was updated to include "(Bill of Materials)" for clarity, the packaging type was changed from jar to pom (the correct format for BOMs), and a description was added to document the BOM's purpose of managing multiple NullAway artifacts. No public API changes were introduced.

Possibly related PRs

Suggested reviewers

  • yuxincs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating POM properties (name, packaging, and description) for the nullaway-bom module.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bom-packaging
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a29dce and d46dcc9.

📒 Files selected for processing (1)
  • nullaway-bom/gradle.properties (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build and test on macos-latest
  • GitHub Check: Build caffeine with snapshot
  • GitHub Check: Build and test on windows-latest
🔇 Additional comments (1)
nullaway-bom/gradle.properties (1)

17-20: LGTM! Correctly configures the BOM artifact.

These changes properly configure this module as a Bill of Materials:

  • The updated name clearly identifies this as a BOM artifact.
  • The packaging change from "jar" to "pom" is essential and correct—BOMs must use "pom" packaging.
  • The description provides clear documentation of the BOM's purpose for dependency management.

All changes align with Maven/Gradle best practices for BOMs.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@msridhar msridhar requested a review from yuxincs December 19, 2025 19:27
@msridhar msridhar merged commit 77d1651 into master Dec 19, 2025
10 of 11 checks passed
@msridhar msridhar deleted the bom-packaging branch December 19, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuxincs yuxincs yuxincs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msridhar @yuxincs