Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1382 +/- ##
=========================================
Coverage 88.35% 88.35%
Complexity 2642 2642
=========================================
Files 97 97
Lines 8888 8888
Branches 1775 1775
=========================================
Hits 7853 7853
Misses 518 518
Partials 517 517 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughThe pull request adds a new changelog entry for Version 0.12.15 at the top of the CHANGELOG.md file. This version documents the release of a BOM artifact, multiple bug fixes, and JSpecify-related improvements. The changelog captures changes including a URL fix for RequireExplicitNullMarking, annotation handling on type variables, dataflow recursion adjustments, type-variable specific behavior in JSpecify, method type parameter inclusion in astubx files, a new nullaway-bom project, lambda body dataflow analysis improvements, and refactoring notes for Handler class modifications. The existing Version 0.12.14 section remains unchanged. Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-14T18:50:06.159Z
Learnt from: msridhar
Repo: uber/NullAway PR: 1245
File: guava-recent-unit-tests/src/test/java/com/uber/nullaway/guava/NullAwayGuavaParametricNullnessTests.java:101-102
Timestamp: 2025-08-14T18:50:06.159Z
Learning: In NullAway JSpecify tests, when JDK version requirements exist due to bytecode annotation reading capabilities, prefer failing tests over skipping them on unsupported versions to ensure CI catches regressions and enforces proper JDK version usage for developers.
Applied to files:
CHANGELOG.md
📚 Learning: 2025-08-29T18:41:43.584Z
Learnt from: msridhar
Repo: uber/NullAway PR: 1259
File: jdk-recent-unit-tests/src/test/java/com/uber/nullaway/jdk17/SwitchTests.java:318-321
Timestamp: 2025-08-29T18:41:43.584Z
Learning: Classes annotated with NullMarked are analyzed by NullAway even if they are not in packages specified by the AnnotatedPackages configuration. The NullMarked annotation guarantees NullAway analysis.
Applied to files:
CHANGELOG.md
📚 Learning: 2025-08-28T04:54:20.953Z
Learnt from: msridhar
Repo: uber/NullAway PR: 1248
File: nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java:847-857
Timestamp: 2025-08-28T04:54:20.953Z
Learning: In NullAway's GenericsChecks.java, NewClassTree support for explicit type argument substitution requires more extensive changes beyond just modifying the conditional in compareGenericTypeParameterNullabilityForCall. The maintainers prefer to handle NewClassTree support in a separate follow-up rather than expanding the scope of PRs focused on specific issues like super constructor calls.
Applied to files:
CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build and test on macos-latest
- GitHub Check: Build caffeine with snapshot
- GitHub Check: Build and test on windows-latest
🔇 Additional comments (1)
CHANGELOG.md (1)
4-19: Changelog structure and content look solid.The new Version 0.12.15 section follows the established format consistently: clear introductory paragraph explaining the release focus (BOM artifact and improvements), well-organized bullet points covering bug fixes and enhancements, and a maintenance subsection with proper indentation. All changes are attributed with PR numbers and contributor credits where applicable. Once the minor formatting issue on line 14 is corrected, this changelog entry is ready.
| * Handle annotations on type variables in return and field types (#1371) | ||
| * Change how recursive calls to dataflow are detected (#1374) | ||
| * JSpecify: use type on identifier when its type is a type variable (#1378) | ||
| * Include method type parameters in astubx files. by @haewiful (#1370) |
There was a problem hiding this comment.
Remove extra period before contributor attribution.
Line 14 has an inconsistent formatting pattern. The period before "by @haewiful" should be removed to match the established convention in the changelog (see lines 48, 51, and others).
🔎 Proposed fix
-* Include method type parameters in astubx files. by @haewiful (#1370)
+* Include method type parameters in astubx files by @haewiful (#1370)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * Include method type parameters in astubx files. by @haewiful (#1370) | |
| * Include method type parameters in astubx files by @haewiful (#1370) |
🤖 Prompt for AI Agents
In CHANGELOG.md around line 14, remove the stray period before the contributor
attribution so the entry reads "* Include method type parameters in astubx files
by @haewiful (#1370)" (ensure a single space before "by" and no extra
punctuation), matching the established changelog formatting used elsewhere.
Summary by CodeRabbit
Bug Fixes
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.