Skip to content

Support @NullMarked on modules#1216

Merged
msridhar merged 4 commits intomasterfrom
nullmarked-module
May 23, 2025
Merged

Support @NullMarked on modules#1216
msridhar merged 4 commits intomasterfrom
nullmarked-module

Conversation

@msridhar
Copy link
Copy Markdown
Collaborator

@msridhar msridhar commented May 21, 2025

Fixes #1083. NullAway now recognizes @NullMarked on module-info.java files. Note that module annotations can only be observed for a jar when it appears on the module path. If the jar is on the classpath the module annotations won't be seen (see jspecify/jspecify#496 (comment)).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (56c7f2b) to head (986b37a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1216   +/-   ##
=========================================
  Coverage     88.29%   88.29%           
- Complexity     2347     2351    +4     
=========================================
  Files            89       89           
  Lines          7652     7657    +5     
  Branches       1531     1533    +2     
=========================================
+ Hits           6756     6761    +5     
  Misses          450      450           
  Partials        446      446           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msridhar msridhar marked this pull request as ready for review May 21, 2025 16:32
@msridhar msridhar requested review from akshayutture and yuxincs May 21, 2025 16:34
@msridhar msridhar merged commit ec6d829 into master May 23, 2025
12 checks passed
@msridhar msridhar deleted the nullmarked-module branch May 23, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Nullmarked on module-info (JPMS)

2 participants