Conversation
julien-deramond
approved these changes
Jul 28, 2024
Member
julien-deramond
left a comment
There was a problem hiding this comment.
Tested the modification to js/src/dom/manipulator.js and confirmed it doesn't cause any regressions. The other dependencies have no impact and require no modifications on our side. LGTM!
eeff5cb to
d37f829
Compare
* @babel/preset-env ^7.24.8 → ^7.25.0 * eslint-plugin-unicorn ^54.0.0 → ^55.0.0 * hugo-bin ^0.126.0 → ^0.127.0 * postcss ^8.4.39 → ^8.4.40 * rollup ^4.19.0 → ^4.19.1 * rtlcss ^4.1.1 → ^4.2.0
Member
Author
|
@julien-deramond when the second parameter is missing it means the length of the array so this was just redundant hence why the good guys at xo added the rule :) stylelint 16.8.0 seems to have new FPs so I kept it back for now and we;ll check the dependabot PR when it runs. |
Member
Author
|
@julien-deramond Actually they are not FPs, so it might be worth seeing if we can reduce the duplicate selectors in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues