Docs: Add main element to Cheatsheet Examples#40577
Merged
julien-deramond merged 1 commit intotwbs:mainfrom Jun 25, 2024
Merged
Docs: Add main element to Cheatsheet Examples#40577julien-deramond merged 1 commit intotwbs:mainfrom
julien-deramond merged 1 commit intotwbs:mainfrom
Conversation
Fixes an accessibility issue reported by Axe Core. https://dequeuniversity.com/rules/axe/4.8/landmark-one-main
julien-deramond
approved these changes
Jun 25, 2024
Member
julien-deramond
left a comment
There was a problem hiding this comment.
LGTM, thanks @coliff for the patch.
I'm handing the PR over to @patrickhlauke for a11y final check, just to be 100% sure 😇
patrickhlauke
approved these changes
Jun 25, 2024
Member
patrickhlauke
left a comment
There was a problem hiding this comment.
Noting that it's only a best practice, not an actual failure...but sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an accessibility issue reported by Axe Core.
REF: https://dequeuniversity.com/rules/axe/4.8/landmark-one-main
Motivation & Context
Makes is easier for accessibility tools to navigate by landmarks
Type of changes
Checklist
npm run lint)Live previews
Related issues