Search: Fix modal on mobile chromium based browsers#39739
Merged
julien-deramond merged 2 commits intomainfrom Mar 8, 2024
Merged
Search: Fix modal on mobile chromium based browsers#39739julien-deramond merged 2 commits intomainfrom
julien-deramond merged 2 commits intomainfrom
Conversation
julien-deramond
approved these changes
Mar 8, 2024
Member
julien-deramond
left a comment
There was a problem hiding this comment.
LGTM! The position: fixed doesn't seem to imply some visual regressions and it fixes the issue that was reproducible on basically all browsers on my side.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the
positionto have always the same.Motivation & Context
Some issue on mobile breakpoint when using Chrome or Chromium based with search modal from Algolia.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Fixes #39665.