Conversation
Cast to string when comparing the versions, otherwise we were comparing numbers with strings Fixes 404 errors in the version picker
julien-deramond
approved these changes
Mar 5, 2024
Member
julien-deramond
left a comment
There was a problem hiding this comment.
Alternatively, we could just make sure we are using quoted strings in front matter, but this should work in both cases.
Works nicely with or without the quoted strings in the frontmatter so LGTM to be merged as is. Good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cast to string when comparing the versions, otherwise we were comparing numbers with strings.
Also, move checks to variables.
Fixes 404 errors in the version picker.
Alternatively, we could just make sure we are using quoted strings in front matter, but this should work in both cases.
(check the version picker)
main: https://twbs-bootstrap.netlify.app/docs/5.3/helpers/icon-link/
Preview: https://deploy-preview-39738--twbs-bootstrap.netlify.app/docs/5.3/helpers/icon-link/
Split from #39724