Change floating label placeholder's color#39494
Merged
julien-deramond merged 3 commits intotwbs:mainfrom Mar 19, 2024
Merged
Conversation
|
👍 Yes! I've often been confused by the current text color since it looks like a value rather than a placeholder. |
louismaximepiton
approved these changes
Jan 5, 2024
Member
louismaximepiton
left a comment
There was a problem hiding this comment.
The solution looks fine from a CSS point of view. Any thoughts @mdo ?
mdo
approved these changes
Jan 9, 2024
Member
mdo
left a comment
There was a problem hiding this comment.
Do we need to modify the $form-floating-transition value as well?
Member
|
I think it's fine as-is. |
|
Is there anything preventing this from being merged? |
Member
For the moment, the target of this one is v5.4.0. The next version will probably be a v5.3.x. We'll evaluate when to merge it at the appropriate time. |
mdo
approved these changes
Mar 18, 2024
Member
mdo
left a comment
There was a problem hiding this comment.
I think we can add this in v5.3.4.
julien-deramond
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the floating labels placeholder's text color from black to light gray (
opacity: 0.65).I removed the styling from the other
labeltags under.form-selectand.form-control:-webkit-autofillparents as everylabelshould now have the same behavior.Motivation & Context
As requested in issue #39420
Type of changes
Checklist
npm run lint)Live previews
https://deploy-preview-39494--twbs-bootstrap.netlify.app/docs/5.3/forms/floating-labels/#example/
Related issues
#39420