Skip to content

Optimisations#1133

Merged
epage merged 2 commits intotoml-rs:mainfrom
dimbleby:micro-optimisations
Mar 31, 2026
Merged

Optimisations#1133
epage merged 2 commits intotoml-rs:mainfrom
dimbleby:micro-optimisations

Conversation

@dimbleby
Copy link
Copy Markdown
Contributor

@dimbleby dimbleby commented Mar 30, 2026 •
edited
Loading

A couple of small optimisations:

  • avoid unnecessary path cloning in get_values()
  • avoid needlessly collecting one already-owned Vec into another

The second seems easy, the first is maybe a little bit on the clever side for modest gain.

If you want both, or neither, thats easy: merge or reject. If you want one but not the other let me know.

github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 30, 2026
View reviewed changes
Comment thread crates/toml_edit/src/inline_table.rs Fixed
Comment thread crates/toml_edit/src/inline_table.rs Fixed
Comment thread crates/toml_edit/src/inline_table.rs Fixed
Comment thread crates/toml_edit/src/table.rs Fixed
Comment thread crates/toml_edit/src/table.rs Fixed
Comment thread crates/toml_edit/src/table.rs Fixed
Comment thread crates/toml_edit/src/table.rs Fixed
Comment thread crates/toml_edit/src/table.rs Fixed
Comment thread crates/toml_edit/src/table.rs Fixed
Comment thread crates/toml_edit/src/table.rs Fixed
@dimbleby dimbleby force-pushed the micro-optimisations branch 2 times, most recently from eb37e26 to 1be22da Compare March 30, 2026 10:26
epage
epage reviewed Mar 30, 2026
View reviewed changes
Comment thread crates/toml_edit/src/inline_table.rs Outdated
epage
epage reviewed Mar 30, 2026
View reviewed changes
Comment thread crates/toml_edit/src/inline_table.rs Outdated
@dimbleby dimbleby force-pushed the micro-optimisations branch from 1be22da to 4de79db Compare March 30, 2026 23:37
epage
epage reviewed Mar 31, 2026
View reviewed changes
Comment thread crates/toml_edit/src/table.rs Outdated
epage
epage reviewed Mar 31, 2026
View reviewed changes
Comment thread crates/toml_edit/src/inline_table.rs Outdated
dimbleby and others added 2 commits March 31, 2026 16:36
@dimbleby
perf(edit): Reduce allocs in append_values
8119d76 
Use push/pop on a shared Vec instead of cloning the
parent path for every child in append_values() and
append_all_values(). Paths are now only cloned when
storing leaf values in the result.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dimbleby
perf(edit): Remove redundant Vec collect
b8578fa 
values.values is already a Vec<Item>, so
into_iter().collect::<Vec<_>>() just copies it
needlessly. Use the owned Vec directly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dimbleby dimbleby force-pushed the micro-optimisations branch from 7cb7719 to b8578fa Compare March 31, 2026 15:37
@epage
Copy link
Copy Markdown
Member

epage commented Mar 31, 2026

Thanks!

@epage epage merged commit c11d7d7 into toml-rs:main Mar 31, 2026
15 checks passed
@dimbleby dimbleby deleted the micro-optimisations branch March 31, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epage epage epage left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimbleby @epage @github-advanced-security