Skip to content

🌐 Add Bengali translation for docs/bn/docs/index.md#9177

Merged
tiangolo merged 19 commits intofastapi:masterfrom
Fahad-Md-Kamal:translation-bangla
Jan 10, 2024
Merged

🌐 Add Bengali translation for docs/bn/docs/index.md#9177
tiangolo merged 19 commits intofastapi:masterfrom
Fahad-Md-Kamal:translation-bangla

Conversation

@Fahad-Md-Kamal
Copy link
Copy Markdown
Contributor

  • Translated Index page into Bangla

@Fahad-Md-Kamal Fahad-Md-Kamal changed the title Translated Index page into bangla Add Bangla translation for Index page Mar 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2023

📝 Docs preview for commit 3a7e5b5 at: https://640256d2f086d419196afbcd--fastapi.netlify.app

@tiangolo tiangolo changed the title Add Bangla translation for Index page 🌐 Add Bengali translation for docs/bn/docs/index.md Mar 4, 2023
@tiangolo tiangolo added lang-all Translations awaiting-review lang-bn Bengali translations and removed awaiting-review labels Mar 4, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2023

📝 Docs preview for commit 57ea541 at: https://6404b4eef041a328652021b6--fastapi.netlify.app

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 7, 2023

📝 Docs preview for commit 9f7a1b3 at: https://6406e5cc1f0bc64cf86edce7--fastapi.netlify.app

Copy link
Copy Markdown

@baseplate-admin baseplate-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

প্রোডাকশন

@baseplate-admin
Copy link
Copy Markdown

baseplate-admin commented Mar 8, 2023

but the Bangla here looks banglish tbh.

Can you translate English words to Bangla instead of using phonetic libraries ?

Copy link
Copy Markdown

@baseplate-admin baseplate-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance = ক্ষমতা

Copy link
Copy Markdown

@baseplate-admin baseplate-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source Code = উৎস

Copy link
Copy Markdown

@baseplate-admin baseplate-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature develop = নতুন বৈশিষ্ট্য তৈরি

@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview for commit a413c63 at: https://640ab51432c4993f0b9bb522--fastapi.netlify.app

@Fahad-Md-Kamal
Copy link
Copy Markdown
Contributor Author

but the Bangla here looks banglish tbh.

Can you translate English words to Bangla instead of using phonetic libraries ?

Thank you for the feedback. @baseplate-admin

To be honest.
I wanted to keep the words that we use in our day-to-day life in the industry so that in terms of native readers reading it, they can understand the familiar words of the industry. Such as I have never heard of any Bangla word used instead of the English word 'performance' 😁.

By the way, I'm updating it 😀.

Comment thread docs/bn/docs/index.md Outdated
Comment thread docs/bn/docs/index.md Outdated
Comment thread docs/bn/docs/index.md Outdated
@baseplate-admin
Copy link
Copy Markdown

baseplate-admin commented Mar 10, 2023

I wanted to keep the words that we use in our day-to-day life in the industry so that in terms of native readers reading it, they can understand the familiar words of the industry.

While your reasoning is good. I think translating it to Bangla would help our people ( who doesn't know English terms that well ) to shine :)


But yes i am nitpicking somethings here to be honest.


Please review the errors i have mentioned :)

Comment thread docs/bn/docs/index.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview for commit b8d52c0 at: https://640e8c8b611f617c720901d9--fastapi.netlify.app

Comment thread docs/bn/docs/index.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 3470450 at: https://640ebe86523c032065b62bc0--fastapi.netlify.app

@baseplate-admin
Copy link
Copy Markdown

baseplate-admin commented Mar 13, 2023

Looks 60% good. I will review after 20 March :)

Comment thread docs/bn/docs/index.md Outdated
Comment thread docs/bn/docs/index.md
@Fahad-Md-Kamal
Copy link
Copy Markdown
Contributor Author

Was really busy with work. @baseplate-admin Let's complete this time.

@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 3ac0a31 at: https://646040c5ef063b32359ff2ea--fastapi.netlify.app

@baseplate-admin
Copy link
Copy Markdown

baseplate-admin commented May 14, 2023

Looks okay :)

Thanks for listening to me

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 555c1ed at: https://6487100c58c5bd2a5bc7f010--fastapi.netlify.app

@baseplate-admin
Copy link
Copy Markdown

Are we finally merging this ? 👀 ( that'd be awesome )

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit c474d45 at: https://649a2fb07ba2252057e3aac4--fastapi.netlify.app

@tiangolo
Copy link
Copy Markdown
Member

@baseplate-admin I just need 2 approvals and I'll merge it! 🎉

I see you gave a review, but asked for changes. If you think this is ready, just add your PR approval, and I'll know that this is ready and can be merged. 🤓

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 198788a at: https://649a32a5c3bf90222aa9e4e1--fastapi.netlify.app

Copy link
Copy Markdown

@baseplate-admin baseplate-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i forgot about this.

LGTM

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Jan 9, 2024

Nice, thank you for the contribution @Fahad-Md-Kamal! 🍰

And thanks for the reviews @sany2k8, @SmilingBytes, @baseplate-admin 🚀

@Fahad-Md-Kamal
Copy link
Copy Markdown
Contributor Author

Nice, thank you for the contribution @Fahad-Md-Kamal! 🍰

And thanks for the reviews @sany2k8, @SmilingBytes, @baseplate-admin 🚀

@tiangolo most welcome

Thank you all.

Looking forward to contribute more.

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Jan 9, 2024

📝 Docs preview for commit fc67536 at: https://a2944995.fastapitiangolo.pages.dev

@tiangolo tiangolo merged commit 06bf778 into fastapi:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-bn Bengali translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants