🌐 Add Bengali translation for docs/bn/docs/index.md#9177
🌐 Add Bengali translation for docs/bn/docs/index.md#9177tiangolo merged 19 commits intofastapi:masterfrom Fahad-Md-Kamal:translation-bangla
docs/bn/docs/index.md#9177Conversation
Fahad-Md-Kamal
commented
Mar 3, 2023
- Translated Index page into Bangla
|
📝 Docs preview for commit 3a7e5b5 at: https://640256d2f086d419196afbcd--fastapi.netlify.app |
docs/bn/docs/index.md
|
📝 Docs preview for commit 57ea541 at: https://6404b4eef041a328652021b6--fastapi.netlify.app |
Missed lines for translation
|
📝 Docs preview for commit 9f7a1b3 at: https://6406e5cc1f0bc64cf86edce7--fastapi.netlify.app |
|
but the Bangla here looks banglish tbh. Can you translate English words to Bangla instead of using phonetic libraries ? |
baseplate-admin
left a comment
There was a problem hiding this comment.
feature develop = নতুন বৈশিষ্ট্য তৈরি
|
📝 Docs preview for commit a413c63 at: https://640ab51432c4993f0b9bb522--fastapi.netlify.app |
Thank you for the feedback. @baseplate-admin To be honest. By the way, I'm updating it 😀. |
While your reasoning is good. I think translating it to Bangla would help our people ( who doesn't know English terms that well ) to shine :) But yes i am nitpicking somethings here to be honest. Please review the errors i have mentioned :) |
|
📝 Docs preview for commit b8d52c0 at: https://640e8c8b611f617c720901d9--fastapi.netlify.app |
|
📝 Docs preview for commit 3470450 at: https://640ebe86523c032065b62bc0--fastapi.netlify.app |
|
Looks 60% good. I will review after 20 March :) |
|
Was really busy with work. @baseplate-admin Let's complete this time. |
|
📝 Docs preview for commit 3ac0a31 at: https://646040c5ef063b32359ff2ea--fastapi.netlify.app |
|
Looks okay :) Thanks for listening to me |
|
📝 Docs preview for commit 555c1ed at: https://6487100c58c5bd2a5bc7f010--fastapi.netlify.app |
|
Are we finally merging this ? 👀 ( that'd be awesome ) |
|
📝 Docs preview for commit c474d45 at: https://649a2fb07ba2252057e3aac4--fastapi.netlify.app |
|
@baseplate-admin I just need 2 approvals and I'll merge it! 🎉 I see you gave a review, but asked for changes. If you think this is ready, just add your PR approval, and I'll know that this is ready and can be merged. 🤓 |
|
📝 Docs preview for commit 198788a at: https://649a32a5c3bf90222aa9e4e1--fastapi.netlify.app |
baseplate-admin
left a comment
There was a problem hiding this comment.
Sorry, i forgot about this.
LGTM
|
Nice, thank you for the contribution @Fahad-Md-Kamal! 🍰 And thanks for the reviews @sany2k8, @SmilingBytes, @baseplate-admin 🚀 |
@tiangolo most welcome Thank you all. Looking forward to contribute more. |
|
📝 Docs preview for commit fc67536 at: https://a2944995.fastapitiangolo.pages.dev |