Skip to content

🌐 Add Persian translation for docs/fa/docs/features.md#5887

Merged
tiangolo merged 7 commits intofastapi:masterfrom
amirilf:master
Jan 9, 2024
Merged

🌐 Add Persian translation for docs/fa/docs/features.md#5887
tiangolo merged 7 commits intofastapi:masterfrom
amirilf:master

Conversation

@amirilf
Copy link
Copy Markdown
Contributor

@amirilf amirilf commented Jan 16, 2023

Hi, this is the translation of the features page for Persian language.

@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 0c4a993 at: https://63c534660b3413380df292d7--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add translation of 'fa/features' page 🌐 Add Persian translation for docs/fa/docs/features.md Feb 7, 2023
@tiangolo tiangolo added lang-all Translations awaiting-review lang-fa Persian translations labels Feb 7, 2023
@github-actions github-actions Bot mentioned this pull request Feb 7, 2023
Copy link
Copy Markdown
Contributor

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to go through it again and avoid translating word by word and use original words like header, cookie, etc as is. Good work BTW 👍

Comment thread docs/fa/docs/features.md Outdated
Comment thread docs/fa/docs/features.md Outdated
Comment thread docs/fa/docs/features.md Outdated
* اساس و اولیه HTTP.
* **OAuth2** (همچنین با **JWT tokens**). آموزش را در [OAuth2 with JWT](tutorial/security/oauth2-jwt.md){.internal-link target=_blank} مشاهده کنید.
* کلید های API:
* <abbr title="Headers">سرصفحه ها</abbr>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to translate every single word, some translated words look more confusing.
I'd wait for more input on this.

Comment thread docs/fa/docs/features.md Outdated
* **OAuth2** (همچنین با **JWT tokens**). آموزش را در [OAuth2 with JWT](tutorial/security/oauth2-jwt.md){.internal-link target=_blank} مشاهده کنید.
* کلید های API:
* <abbr title="Headers">سرصفحه ها</abbr>
* <abbr title="Query parameters">پارامترهای پرسمان</abbr>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 43b2106 at: https://649a23fab14d051907046035--fastapi.netlify.app

@amirilf amirilf requested a review from aminalaee September 8, 2023 18:28
@amirilf
Copy link
Copy Markdown
Contributor Author

amirilf commented Dec 17, 2023

@tiangolo ?

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Jan 9, 2024

Awesome, thanks @amirilf! 🚀

And thanks for the reviews @aminkhani, @erfan-rfmhr, @aminalaee! 🍰

@tiangolo tiangolo enabled auto-merge (squash) January 9, 2024 15:30
@tiangolo tiangolo merged commit 7d8241a into fastapi:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-fa Persian translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants