🔧 Fix Ruff configuration unintentionally enabling and re-disabling mccabe complexity check#10893
Merged
tiangolo merged 2 commits intofastapi:masterfrom Jan 12, 2024
Merged
🔧 Fix Ruff configuration unintentionally enabling and re-disabling mccabe complexity check#10893tiangolo merged 2 commits intofastapi:masterfrom
tiangolo merged 2 commits intofastapi:masterfrom
Conversation
…plexity check Enabling "C" turns on complexity checks (C90, mccabe), which is unintended Instead, enable "C4" to get flake8-comprehensions checks See docs at https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4
Member
|
Nice, thanks @jiridanek! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling
"C"turns on complexity checks (C90, mccabe), which is unintended. Instead, enable"C4"to get flake8-comprehensions checksSee docs at https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4