Skip to content

🌐 Add Ukrainian translation for docs/uk/docs/index.md#10362

Merged
alejsdev merged 15 commits intofastapi:masterfrom
rostik1410:translations/docs/index
Jan 9, 2024
Merged

🌐 Add Ukrainian translation for docs/uk/docs/index.md#10362
alejsdev merged 15 commits intofastapi:masterfrom
rostik1410:translations/docs/index

Conversation

@rostik1410
Copy link
Copy Markdown
Contributor

related #1748
based on #5178

@rostik1410
Copy link
Copy Markdown
Contributor Author

@akarev0 you said that I can ask you to help if I will work on it) Could you pls make a review?

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Oct 1, 2023

📝 Docs preview for commit f632816 at: https://79e51118.fastapitiangolo.pages.dev

@rostik1410
Copy link
Copy Markdown
Contributor Author

@ArtemKhymenko could you pls also help with a review?

Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
@rostik1410
Copy link
Copy Markdown
Contributor Author

@akarev0 Thanks a lot!!!! Could you pls look at some of my answers while I'll fix your suggestions

@rostik1410 rostik1410 requested a review from akarev0 October 1, 2023 14:31
@rostik1410
Copy link
Copy Markdown
Contributor Author

@akarev0 Thanks again, I took all your comments and added some improvements of my own. Let me know if it is good for you when you have time

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Oct 1, 2023

📝 Docs preview for commit 0f15c8d at: https://c405bf84.fastapitiangolo.pages.dev

@akarev0
Copy link
Copy Markdown

akarev0 commented Oct 2, 2023

@rostik1410 only one thing to mention from my side, I thinking about update тіло запиту for вміст запиту I think it makes more sense

@tiangolo tiangolo changed the title 🌐 Add Ukrainian translation for docs/uk/docs/index.md 🌐 Add Ukrainian translation for docs/uk/docs/index.md Oct 2, 2023
@tiangolo tiangolo added lang-all Translations awaiting-review lang-uk Ukrainian translations labels Oct 2, 2023
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
Comment thread docs/uk/docs/index.md Outdated
@rostik1410 rostik1410 requested a review from mezgoodle October 10, 2023 15:46
@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 8d2188e at: https://e4d1edce.fastapitiangolo.pages.dev

@akarev0
Copy link
Copy Markdown

akarev0 commented Nov 27, 2023

@romashevchenko could we also update this to uk - українська, does it makes any sense? Just uk looks more like united kingdom or something like for me xD
image

@akarev0
Copy link
Copy Markdown

akarev0 commented Nov 27, 2023

according to ISO we could use ukr to be more verbose

@mezgoodle
Copy link
Copy Markdown
Contributor

@romashevchenko could we also update this to uk - українська, does it makes any sense? Just uk looks more like united kingdom or something like for me xD image

вже колись бачив відповідь на таке, що наш код мови - uk. Там не символ країни, а саме мови, відповідно для united kingdom це english - en.

@akarev0
Copy link
Copy Markdown

akarev0 commented Nov 27, 2023

@mezgoodle судячи з цього там просто стандарт, а які вимоги у репозиторію до цього не знаю
image

@mezgoodle
Copy link
Copy Markdown
Contributor

mezgoodle commented Nov 27, 2023

@mezgoodle судячи з цього там просто стандарт, а які вимоги у репозиторію до цього не знаю image

uk має бути нормально(і достатньо)

@akarev0
Copy link
Copy Markdown

akarev0 commented Nov 27, 2023

@mezgoodle я за те щоб просто додати припис українська аби одразу було видно

@rostik1410
Copy link
Copy Markdown
Contributor Author

rostik1410 commented Nov 28, 2023

@akarev0 @mezgoodle ви не найкраще місце для обговорення коду мови знайшли xD бо це не відноситься до цього конкретного перекладу) автор вирішить що тут досі щось не так) Я можу спробувати знайти, що відповідає за ту випадашку і додати Українська окремим пул реквестом

@rostik1410
Copy link
Copy Markdown
Contributor Author

@romashevchenko could we also update this to uk - українська, does it makes any sense? Just uk looks more like united kingdom or something like for me xD image

вже колись бачив відповідь на таке, що наш код мови - uk. Там не символ країни, а саме мови, відповідно для united kingdom це english - en.

це швидше за все якраз моя відповідь і була) під іншим ПРом

@rostik1410
Copy link
Copy Markdown
Contributor Author

@tiangolo hey, could you pls merge it? It already has the required approvals. All comments were addressed

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 147f61c at: https://53ffeeaa.fastapitiangolo.pages.dev

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Dec 5, 2023

📝 Docs preview for commit 373d515 at: https://32993eb4.fastapitiangolo.pages.dev

Comment thread docs/uk/docs/index.md Outdated
@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit b57334b at: https://51a95565.fastapitiangolo.pages.dev

@rostik1410
Copy link
Copy Markdown
Contributor Author

@tiangolo Hey, sorry for disturbing you. This PR waiting for the merge already a long time. Could you pls merge it? FYI

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 52500ed at: https://5ab102ea.fastapitiangolo.pages.dev

@alejsdev
Copy link
Copy Markdown
Member

alejsdev commented Jan 9, 2024

Thank you for your help! @rostik1410 🐱

And thanks for the reviews @akarev0 @mezgoodle @OlegZv @romashevchenko ✌️

@alejsdev alejsdev enabled auto-merge (squash) January 9, 2024 15:52
@alejsdev alejsdev merged commit e986894 into fastapi:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-uk Ukrainian translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants