Update PR template with more specific wording#7751
Merged
eddumelendez merged 1 commit intotestcontainers:mainfrom Nov 2, 2023
gvenzl:PR-text-update
Merged
Update PR template with more specific wording#7751eddumelendez merged 1 commit intotestcontainers:mainfrom gvenzl:PR-text-update
eddumelendez merged 1 commit intotestcontainers:mainfrom
gvenzl:PR-text-update
Conversation
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
eddumelendez
approved these changes
Nov 2, 2023
Member
|
Thanks for your feedback and contribution, @gvenzl ! |
Contributor
Author
|
You are very welcome! |
fokion
pushed a commit
to fokion/testcontainers-java
that referenced
this pull request
Jan 18, 2025
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just adds some more explicit wording for new module contributions into the PR template. As a newcomer, I found the current wording at first a bit confusing, it was clear once I understood which files were meant.
This PR should help other newcomers to not run into any confusion and be more productive.