Skip to content

fix: make the panels compatible with dark theme#52

Merged
tcmetzger merged 1 commit intotcmetzger:mainfrom
12rambau:sphinx-design
Mar 20, 2023
Merged

fix: make the panels compatible with dark theme#52
tcmetzger merged 1 commit intotcmetzger:mainfrom
12rambau:sphinx-design

Conversation

@12rambau
Copy link
Copy Markdown
Collaborator

@12rambau 12rambau commented Mar 19, 2023

Fix #48
I realized we were using the sphinx_design lib already, it's just the panel color header you selected that has 0 contrast in dark theme.

  • I changed the header color to "none" so it works fine with bothe themes
  • I replaced the emoji with icons so that it works even on computer that don't have the emoji font (as we embed the fontawesome icons in the website)

@12rambau 12rambau marked this pull request as ready for review March 19, 2023 11:58
Copy link
Copy Markdown
Owner

@tcmetzger tcmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tcmetzger tcmetzger merged commit 9bd097e into tcmetzger:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

switch from sphinx-panel to sphinx-design

2 participants