Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3307 +/- ##
============================================
+ Coverage 92.95% 93.00% +0.04%
+ Complexity 3542 3539 -3
============================================
Files 382 382
Lines 9389 9388 -1
Branches 760 755 -5
============================================
+ Hits 8728 8731 +3
Misses 468 468
+ Partials 193 189 -4
|
dilipkrish
approved these changes
May 8, 2020
Member
dilipkrish
left a comment
There was a problem hiding this comment.
👍 Just had one questions about a change.
| List<SecurityReference> securityReferences = new ArrayList<>(); | ||
|
|
||
| Map<String, Set<Model>> globalModelMap = new TreeMap<>(); | ||
| Map<String, Set<Model>> globalModelMap = new HashMap<>(); |
Member
There was a problem hiding this comment.
This was tree map because it preserves the order of the models. Does this need to change to hash map?
Member
Author
There was a problem hiding this comment.
Iterating over HashMap is faster than iterating TreeMap, and order is not important any more
Member
|
Thank you @MaksimOrlov! |
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR returns support for cache. Variable
parameterIdhas been removed from.equals()and.hashCode()methods ofModelContext. Speed on load testing shows increasing from 130 test controllers to 300 controllers per second.