Skip to content

Extends @SuppressFBWarnings to allow regex and exact matches#3102

Merged
gtoison merged 6 commits intospotbugs:masterfrom
gtoison:issue-2938
Sep 29, 2024
Merged

Extends @SuppressFBWarnings to allow regex and exact matches#3102
gtoison merged 6 commits intospotbugs:masterfrom
gtoison:issue-2938

Conversation

@gtoison
Copy link
Copy Markdown
Contributor

@gtoison gtoison commented Sep 4, 2024

Extend the bug suppression, allowing exact (not prefix) bug type match, and regex bug type match

Extend the bug suppression, allowing exact (not prefix) bug type match,
and regex bug type match
Copy link
Copy Markdown
Collaborator

@JuditKnoll JuditKnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotless didn't like this PR, can you please run gradlew spotlessApply?
Can you please add a few tests for this?
Before merging this to master, it would be great to update the documentation about this as well.

Comment thread spotbugs-tests/src/test/java/edu/umd/cs/findbugs/WarningSuppressorTest.java Outdated
Comment thread spotbugsTestCases/src/java/suppress/SuppressedBugs.java
@gtoison gtoison marked this pull request as ready for review September 11, 2024 19:14
Copy link
Copy Markdown
Collaborator

@JuditKnoll JuditKnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to add some info about this feature in the documentation as well, but otherwise LGTM.

@gtoison
Copy link
Copy Markdown
Contributor Author

gtoison commented Sep 12, 2024

I looked for mentions to @SuppressFBWarnings in the documentation but couldn't find any, I guess the javadocs are the docs for now :)

@JuditKnoll
Copy link
Copy Markdown
Collaborator

I looked for mentions to @SuppressFBWarnings in the documentation but couldn't find any, I guess the javadocs are the docs for now :)

First I thought so as well. But it differs a bit. All I could find about suppressing warnings is in the annotations.rst file.

@gtoison gtoison merged commit 6e94d1f into spotbugs:master Sep 29, 2024
@hazendaz hazendaz added this to the SpotBugs 4.9.0 milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants