Some NonNull annotations not recognized#2694
Conversation
|
|
||
| static final ClassDescriptor androidNullable = DescriptorFactory.createClassDescriptor("android/support/annotation/Nullable"); | ||
|
|
||
| static final ClassDescriptor androidNonNull = DescriptorFactory.createClassDescriptor("android/support/annotation/NonNull"); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I looked into what causes the build fail. There is an because the properties field has the annotation edu.umd.cs.findbugs.annotation.Nullable which is added in this PR:spotbugs/spotbugs/src/main/java/edu/umd/cs/findbugs/sarif/Location.java Lines 275 to 276 in a9ed9ef |
|
Thank you very much for looking into it, I did not have much time to investigate but I saw that the code is handling the |
|
Hello @JuditKnoll, The error I see is: |
|
I simply ran I looked at the report which contained that the error is at The strange thing is, that earlier my output was the same as that of the github action check, but now, without any modification to the earlier version, the *There are some other messages in connection with |
|
I think that these warnings are from the spotbugs gradle plugin running on spotbugs' own code, so the analysis itself is done from an already released version, not from the freshly compiled version EDIT: the issue was SpotBug flagging an issue in it's own code (in |
It looks like the error at |
LogicalLocation.properties should be annotated NonNull
|
@gtoison Can you fix merge conflict? |
|
I have merged the conflict |
* test: reproducer for issue spotbugs#2558 * Recognize more nullability annotations * fix: added back check for Eclipse's NonNullByDefault * fix: made eclipseNonNullByDefault a field again since used externally * fix: with the other changes the smoke tests flag that field as NonNull LogicalLocation.properties should be annotated NonNull * doc: added changelog entry * fix: updated the comment now that the false positive is fixed
Added support for:
edu.umd.cs.findbugs.annotations.NonNulledu.umd.cs.findbugs.annotations.Nullableorg.netbeans.api.annotations.common.NonNullorg.netbeans.api.annotations.common.NullAllowedlombok.NonNull