Skip to content

restore unicode_normalize_kc as a deprecated method#504

Merged
dentarg merged 1 commit intosporkmonger:mainfrom
jarthod:restore-unicode_normalize_kc
Apr 9, 2023
Merged

restore unicode_normalize_kc as a deprecated method#504
dentarg merged 1 commit intosporkmonger:mainfrom
jarthod:restore-unicode_normalize_kc

Conversation

@jarthod
Copy link
Copy Markdown
Contributor

@jarthod jarthod commented Apr 6, 2023

As discussed in #492 (comment), this is the PR to restore unicode_normalize_kc as a deprecated method (in case some people where using it). Example of the produced warning:

NOTE: Addressable::IDNA.unicode_normalize_kc is deprecated; use String#unicode_normalize(:nfkc) instead. It will be removed on or after 2023-04.
Addressable::IDNA.unicode_normalize_kc called from benchmark/unicode_normalize.rb:17.

@dentarg dentarg merged commit b460cb7 into sporkmonger:main Apr 9, 2023
@jarthod jarthod deleted the restore-unicode_normalize_kc branch April 11, 2023 14:16
Copy link
Copy Markdown

@Bizzyfortune Bizzyfortune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants