fix: release marked as 'latest' despite make_latest: false#715
Merged
chenrui333 merged 2 commits intosoftprops:masterfrom Mar 14, 2026
Merged
fix: release marked as 'latest' despite make_latest: false#715chenrui333 merged 2 commits intosoftprops:masterfrom
chenrui333 merged 2 commits intosoftprops:masterfrom
Conversation
Collaborator
|
@Boshen how did you test it? do you have any test repo to verify the fix? |
Contributor
Author
Did I miss any info from the PR description? |
|
Can we merge this and make a release ? |
Collaborator
|
gonna get this pr merged today |
The finalizeRelease function was not passing the make_latest parameter when publishing a release (setting draft: false). According to the GitHub API, make_latest defaults to `true` for newly published releases, so `make_latest: false` was being ignored. Ref: https://github.com/octokit/openapi-types.ts/blob/main/packages/openapi-types/types.d.ts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Collaborator
|
Thanks @Boshen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/Boshen/action-gh-release/releases/tag/test-20490403435
To test, I enabled immutable releases, pushed a
make_latest: falsein https://github.com/Boshen/action-gh-release/actions/runs/20490520097/job/58881730816, the release https://github.com/Boshen/action-gh-release/releases/tag/test-20490520097 does not show thelatesttag.Ref: https://github.com/octokit/openapi-types.ts/blob/main/packages/openapi-types/types.d.ts
See
make_latestfor "repos/update-release":AI disclaimer: I used Claude to find and fix the bug, which produced the same result as #706