refactor: move timeSince and timeSinceMillis to common package#1998
Merged
shirou merged 1 commit intoshirou:masterfrom Feb 17, 2026
Merged
refactor: move timeSince and timeSinceMillis to common package#1998shirou merged 1 commit intoshirou:masterfrom
shirou merged 1 commit intoshirou:masterfrom
Conversation
d0f0ef3 to
8f9d77f
Compare
shirou
approved these changes
Feb 17, 2026
Owner
shirou
left a comment
There was a problem hiding this comment.
This PR seems clean, straightforward refactor and the change is minimal in scope. LGTM
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue raised when #1979 was merged. It refactors both timeSince functions into the common package and makes all of the existing calls use those new functions.