Refactor duplicated JPEG segment parsing logic#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_get_size,_get_dpi, and_get_channels, making the code harder to maintain and reason about.Description
_JPEG_NO_SOF_MARKERSto list JPEG markers that are not SOF markers and used it in SOF detection.def _read_jpeg_segment_header(fhandle)to read a JPEG segment header and validate its size.def _seek_to_jpeg_sof(fhandle)to seek to the next SOF marker, replacing inline marker-scanning loops._get_size,_get_dpi, and_get_channelsto call the new helpers and unified JPEG-related exception handling to raiseValueErroron parse errors.Testing
python -m pytest -qand all tests passed (82 passed).Codex Task