fix(typings): make Transactionable compatible with TransactionOptions (#13334)

knoid · papb · web-flow · commit cd2de406a4c8 · 2021-06-26T02:41:14.000-03:00
Co-authored-by: Pedro Augusto de Paula Barbosa &lt;papb1996@gmail.com&gt;
diff --git a/types/lib/transaction.d.ts b/types/lib/transaction.d.ts
@@ -149,7 +149,7 @@ export interface TransactionOptions extends Logging {
   /**
    * Parent transaction.
    */
-  transaction?: Transaction;
+  transaction?: Transaction | null;
 }
 
 export default Transaction;
diff --git a/types/test/models/User.ts b/types/test/models/User.ts
@@ -110,6 +110,11 @@ User.addHook('beforeFind', 'test', (options: FindOptions<UserAttributes>) => {
   return undefined;
 });
 
+User.addHook('afterDestroy', async (instance, options) => {
+  // `options` from `afterDestroy` should be passable to `sequelize.transaction`
+  await instance.sequelize.transaction(options, async () => undefined);
+});
+
 // Model#addScope
 User.addScope('withoutFirstName', {
   where: {

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ export interface TransactionOptions extends Logging {`
`149`	`149`	`/**`
`150`	`150`	`* Parent transaction.`
`151`	`151`	`*/`
`152`		`- transaction?: Transaction;`
	`152`	`+ transaction?: Transaction \| null;`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`export default Transaction;`