Conversation
…d List<SelenideAppiumElement> as a side effect, I fixed method $$.iterator() for mobile elements. Before now, it returned Iterator<SelenideElement> instead of Iterator<SelenideAppiumElement>.
it's needed when AssertJ assert fails, not Selenide's one.
(after opening a Safari browser) instead of clicking "Address" element, just call old good "driver.navigate().to(deepLinkUrl)". It's much more reliable. Also, SAFARI_ELEMENTS_TIMEOUT can now be much shorter because the alert "are you sure you want open deeplink?" appears almost immediatelly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as a side effect, I fixed method $$.iterator() for mobile elements. Before now, it returned
Iterator<SelenideElement>instead ofIterator<SelenideAppiumElement>.