Skip to content

Add dom attribute and property conditions#2783

Merged
asolntsev merged 1 commit intomainfrom
feat/dom-attr-prop
Jul 24, 2024
Merged

Add dom attribute and property conditions#2783
asolntsev merged 1 commit intomainfrom
feat/dom-attr-prop

Conversation

@rosolko
Copy link
Copy Markdown
Collaborator

@rosolko rosolko commented Jul 16, 2024

Proposed changes

Add dom attribute and property conditions.

Or just create a custom command for such cases and keep core lib as clean as possible.

Reference #2782

Checklist

  • Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@sonarqubecloud
Copy link
Copy Markdown

@rosolko rosolko requested review from BorisOsipov and asolntsev July 16, 2024 21:34
Copy link
Copy Markdown
Member

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosolko Currently I don't fully understand in which cases these methods would be useful.

At least some test showing difference in behaviour of getAttribute/getDomAttribute/getDomProperty would be useful.

@rosolko
Copy link
Copy Markdown
Collaborator Author

rosolko commented Jul 20, 2024

Thats why Im also propose custom commands for such cases

@asolntsev asolntsev added this to the 7.4.0 milestone Jul 24, 2024
@asolntsev asolntsev self-assigned this Jul 24, 2024
@asolntsev asolntsev merged commit b97a236 into main Jul 24, 2024
@asolntsev asolntsev deleted the feat/dom-attr-prop branch July 24, 2024 22:30
asolntsev added a commit that referenced this pull request Jul 24, 2024
that show better what is the difference between attribute, domAttribute and domProperty
PetroOv pushed a commit to PetroOv/selenide that referenced this pull request Mar 25, 2025
that show better what is the difference between attribute, domAttribute and domProperty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants