Fix Appium browser when browser is Remote#2664
Merged
asolntsev merged 1 commit intoselenide:mainfrom Feb 29, 2024
Merged
Conversation
|
asolntsev
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pr fixes an issue when a mobile driver uses a remote device (io.appium.java_client.android.AndroidDriver#AndroidDriver(java.net.URL, org.openqa.selenium.Capabilities)), like BrowserStack. After the commit 98c4ee8 - in a case when we use $.setValue() AppiumSetValue command we got 'Unable to create new proxy exception' https://pastebin.com/7amtjpk5 Because AndroidDriver doesn't contain an appropriate constructor. I could not be reproduced on local emulators
Checklist
gradlew check chrome_headless firefox_headlesscommand