Merged
Conversation
|
Still waiting for this to get merged... |
|
Yes, please merge this @scravy! |
|
Any update? @scravy |
|
Bueller? @scravy |
|
Bump? |
|
@fillippeyton (and everyone else) Upgrade to the latest version of WSL and it should work! Download link: https://www.microsoft.com/en-us/software-download/windows10ISO
|
|
Some of us are unable to get the Creators update due to fun enterprise audits... 😢 |
Contributor
Author
|
Yep, it was fixed in WSL some time ago. But I guess there is no point in closing PR atm |
Owner
|
Thank you for this fix! |
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Subsystem for Linux doesn't support os.networkInterfaces() : microsoft/WSL#468
This "fix" returns empty object as if no interfaces were found to prevent syscall error.
Fixes: #8
Fixes react-scripts build on WSL
Thanks to http-party/node-portfinder/pull/42