fix: allow set cookies with localhost#253
Merged
Conversation
Member
|
Thanks! I'm happy with this approach! Let's discuss a bit and merge, and then generate another patch release for our week of excitement. :) |
awaterma
previously approved these changes
Aug 25, 2022
Member
awaterma
left a comment
There was a problem hiding this comment.
Approved; will merge after discussion.
updated CHANGELOG.md to point to the releases page since changelogs are auto-generated now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more tests to cover the breaking use cases noted in #246. e.g.;
new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")Also:
jsdomwhich only allows cookies to be set after applying this fix