GitHub Workflows security hardening#4630
Merged
lukastaegert merged 2 commits intorollup:masterfrom Sep 6, 2022
Merged
Conversation
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #4630 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 210 210
Lines 7373 7373
Branches 2106 2106
=======================================
Hits 7290 7290
Misses 27 27
Partials 56 56 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lukastaegert
approved these changes
Sep 6, 2022
Collaborator
|
This PR has been released as part of rollup@3.0.0-6. Note that this is a pre-release, so to test it, you need to install Rollup via |
lukastaegert
added a commit
that referenced
this pull request
Sep 21, 2022
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
lukastaegert
added a commit
that referenced
this pull request
Sep 21, 2022
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
lukastaegert
added a commit
that referenced
this pull request
Sep 21, 2022
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
lukastaegert
added a commit
that referenced
this pull request
Sep 21, 2022
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from
on: pull_requestfrom external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.