Merged
Conversation
Contributor
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shfmt
[shfmt] reported by reviewdog 🐶
Line 286 in 85cea3a
[shfmt] reported by reviewdog 🐶
Lines 379 to 397 in 85cea3a
[shfmt] reported by reviewdog 🐶
Line 430 in 85cea3a
[shfmt] reported by reviewdog 🐶
Lines 443 to 444 in 85cea3a
[shfmt] reported by reviewdog 🐶
Lines 447 to 448 in 85cea3a
[shfmt] reported by reviewdog 🐶
Lines 451 to 452 in 85cea3a
| ------------------------------------------------------------------------ | ||
| EOF | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| hash_sha256 "$1" | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
Comment on lines
+186
to
+205
| *.tar.gz | *.tgz) tar --no-same-owner -xzf "${tarball}" --strip-components "${strip_components}" ;; | ||
| *.tar.xz) tar --no-same-owner -xJf "${tarball}" --strip-components "${strip_components}" ;; | ||
| *.tar.bz2) tar --no-same-owner -xjf "${tarball}" --strip-components "${strip_components}" ;; | ||
| *.tar) tar --no-same-owner -xf "${tarball}" --strip-components "${strip_components}" ;; | ||
| *.gz) gunzip "${tarball}" ;; | ||
| *.zip) | ||
| # unzip doesn't have a standard --strip-components | ||
| # Workaround: extract to a subdir and move contents up if stripping | ||
| if [ "$strip_components" -gt 0 ]; then | ||
| extract_dir=$(basename "${tarball%.zip}")_extracted | ||
| unzip -q "${tarball}" -d "${extract_dir}" | ||
| # Move contents of the *first* directory found inside extract_dir up | ||
| # This assumes wrap_in_directory=true convention | ||
| first_subdir=$(find "${extract_dir}" -mindepth 1 -maxdepth 1 -type d -print -quit) | ||
| if [ -n "$first_subdir" ]; then | ||
| # Move all contents (* includes hidden files) | ||
| mv "${first_subdir}"/* . | ||
| # Optionally remove the now-empty subdir and the extract_dir | ||
| rmdir "${first_subdir}" | ||
| rmdir "${extract_dir}" |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| *.tar.gz | *.tgz) tar --no-same-owner -xzf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar.xz) tar --no-same-owner -xJf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar.bz2) tar --no-same-owner -xjf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar) tar --no-same-owner -xf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.gz) gunzip "${tarball}" ;; | |
| *.zip) | |
| # unzip doesn't have a standard --strip-components | |
| # Workaround: extract to a subdir and move contents up if stripping | |
| if [ "$strip_components" -gt 0 ]; then | |
| extract_dir=$(basename "${tarball%.zip}")_extracted | |
| unzip -q "${tarball}" -d "${extract_dir}" | |
| # Move contents of the *first* directory found inside extract_dir up | |
| # This assumes wrap_in_directory=true convention | |
| first_subdir=$(find "${extract_dir}" -mindepth 1 -maxdepth 1 -type d -print -quit) | |
| if [ -n "$first_subdir" ]; then | |
| # Move all contents (* includes hidden files) | |
| mv "${first_subdir}"/* . | |
| # Optionally remove the now-empty subdir and the extract_dir | |
| rmdir "${first_subdir}" | |
| rmdir "${extract_dir}" | |
| *.tar.gz | *.tgz) tar --no-same-owner -xzf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar.xz) tar --no-same-owner -xJf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar.bz2) tar --no-same-owner -xjf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar) tar --no-same-owner -xf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.gz) gunzip "${tarball}" ;; | |
| *.zip) | |
| # unzip doesn't have a standard --strip-components | |
| # Workaround: extract to a subdir and move contents up if stripping | |
| if [ "$strip_components" -gt 0 ]; then | |
| extract_dir=$(basename "${tarball%.zip}")_extracted | |
| unzip -q "${tarball}" -d "${extract_dir}" | |
| # Move contents of the *first* directory found inside extract_dir up | |
| # This assumes wrap_in_directory=true convention | |
| first_subdir=$(find "${extract_dir}" -mindepth 1 -maxdepth 1 -type d -print -quit) | |
| if [ -n "$first_subdir" ]; then | |
| # Move all contents (* includes hidden files) | |
| mv "${first_subdir}"/* . | |
| # Optionally remove the now-empty subdir and the extract_dir | |
| rmdir "${first_subdir}" | |
| rmdir "${extract_dir}" | |
| else | |
| log_warn "Could not find subdirectory in zip to strip components from ${extract_dir}" | |
| # Files are extracted in current dir anyway, proceed | |
| fi |
Comment on lines
+207
to
+208
| log_warn "Could not find subdirectory in zip to strip components from ${extract_dir}" | ||
| # Files are extracted in current dir anyway, proceed |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| log_warn "Could not find subdirectory in zip to strip components from ${extract_dir}" | |
| # Files are extracted in current dir anyway, proceed | |
| unzip -q "${tarball}" |
Comment on lines
+210
to
+217
| else | ||
| unzip -q "${tarball}" | ||
| fi | ||
| ;; | ||
| *) | ||
| log_err "untar unknown archive format for ${tarball}" | ||
| return 1 | ||
| ;; |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| else | |
| unzip -q "${tarball}" | |
| fi | |
| ;; | |
| *) | |
| log_err "untar unknown archive format for ${tarball}" | |
| return 1 | |
| ;; | |
| ;; | |
| *) | |
| log_err "untar unknown archive format for ${tarball}" | |
| return 1 | |
| ;; |
| hash_sha256 "$1" | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
Comment on lines
+190
to
+209
| *.tar.gz | *.tgz) tar --no-same-owner -xzf "${tarball}" --strip-components "${strip_components}" ;; | ||
| *.tar.xz) tar --no-same-owner -xJf "${tarball}" --strip-components "${strip_components}" ;; | ||
| *.tar.bz2) tar --no-same-owner -xjf "${tarball}" --strip-components "${strip_components}" ;; | ||
| *.tar) tar --no-same-owner -xf "${tarball}" --strip-components "${strip_components}" ;; | ||
| *.gz) gunzip "${tarball}" ;; | ||
| *.zip) | ||
| # unzip doesn't have a standard --strip-components | ||
| # Workaround: extract to a subdir and move contents up if stripping | ||
| if [ "$strip_components" -gt 0 ]; then | ||
| extract_dir=$(basename "${tarball%.zip}")_extracted | ||
| unzip -q "${tarball}" -d "${extract_dir}" | ||
| # Move contents of the *first* directory found inside extract_dir up | ||
| # This assumes wrap_in_directory=true convention | ||
| first_subdir=$(find "${extract_dir}" -mindepth 1 -maxdepth 1 -type d -print -quit) | ||
| if [ -n "$first_subdir" ]; then | ||
| # Move all contents (* includes hidden files) | ||
| mv "${first_subdir}"/* . | ||
| # Optionally remove the now-empty subdir and the extract_dir | ||
| rmdir "${first_subdir}" | ||
| rmdir "${extract_dir}" |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| *.tar.gz | *.tgz) tar --no-same-owner -xzf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar.xz) tar --no-same-owner -xJf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar.bz2) tar --no-same-owner -xjf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar) tar --no-same-owner -xf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.gz) gunzip "${tarball}" ;; | |
| *.zip) | |
| # unzip doesn't have a standard --strip-components | |
| # Workaround: extract to a subdir and move contents up if stripping | |
| if [ "$strip_components" -gt 0 ]; then | |
| extract_dir=$(basename "${tarball%.zip}")_extracted | |
| unzip -q "${tarball}" -d "${extract_dir}" | |
| # Move contents of the *first* directory found inside extract_dir up | |
| # This assumes wrap_in_directory=true convention | |
| first_subdir=$(find "${extract_dir}" -mindepth 1 -maxdepth 1 -type d -print -quit) | |
| if [ -n "$first_subdir" ]; then | |
| # Move all contents (* includes hidden files) | |
| mv "${first_subdir}"/* . | |
| # Optionally remove the now-empty subdir and the extract_dir | |
| rmdir "${first_subdir}" | |
| rmdir "${extract_dir}" | |
| *.tar.gz | *.tgz) tar --no-same-owner -xzf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar.xz) tar --no-same-owner -xJf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar.bz2) tar --no-same-owner -xjf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.tar) tar --no-same-owner -xf "${tarball}" --strip-components "${strip_components}" ;; | |
| *.gz) gunzip "${tarball}" ;; | |
| *.zip) | |
| # unzip doesn't have a standard --strip-components | |
| # Workaround: extract to a subdir and move contents up if stripping | |
| if [ "$strip_components" -gt 0 ]; then | |
| extract_dir=$(basename "${tarball%.zip}")_extracted | |
| unzip -q "${tarball}" -d "${extract_dir}" | |
| # Move contents of the *first* directory found inside extract_dir up | |
| # This assumes wrap_in_directory=true convention | |
| first_subdir=$(find "${extract_dir}" -mindepth 1 -maxdepth 1 -type d -print -quit) | |
| if [ -n "$first_subdir" ]; then | |
| # Move all contents (* includes hidden files) | |
| mv "${first_subdir}"/* . | |
| # Optionally remove the now-empty subdir and the extract_dir | |
| rmdir "${first_subdir}" | |
| rmdir "${extract_dir}" | |
| else | |
| log_warn "Could not find subdirectory in zip to strip components from ${extract_dir}" | |
| # Files are extracted in current dir anyway, proceed | |
| fi |
Comment on lines
+211
to
+212
| log_warn "Could not find subdirectory in zip to strip components from ${extract_dir}" | ||
| # Files are extracted in current dir anyway, proceed |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| log_warn "Could not find subdirectory in zip to strip components from ${extract_dir}" | |
| # Files are extracted in current dir anyway, proceed | |
| unzip -q "${tarball}" |
Comment on lines
+214
to
+221
| else | ||
| unzip -q "${tarball}" | ||
| fi | ||
| ;; | ||
| *) | ||
| log_err "untar unknown archive format for ${tarball}" | ||
| return 1 | ||
| ;; |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| else | |
| unzip -q "${tarball}" | |
| fi | |
| ;; | |
| *) | |
| log_err "untar unknown archive format for ${tarball}" | |
| return 1 | |
| ;; | |
| ;; | |
| *) | |
| log_err "untar unknown archive format for ${tarball}" | |
| return 1 | |
| ;; |
Comment on lines
+225
to
+226
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| chmod +x "${BINARY_PATH}" | ||
| # Run the binary directly with provided arguments | ||
| log_info "Running ${BINARY_NAME}${TOOL_ARGS:+ with arguments:$TOOL_ARGS}" | ||
| exec "${BINARY_PATH}" $TOOL_ARGS |
Contributor
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
Suggested change
| exec "${BINARY_PATH}" $TOOL_ARGS | |
| exec "${BINARY_PATH}" "$TOOL_ARGS" |
85cea3a to
71ad8e7
Compare
| if [ "$line_filename" = "$BASENAME" ]; then | ||
| return 0 | ||
| fi | ||
| done < "$SUMFILE" |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| done < "$SUMFILE" | |
| done <"$SUMFILE" |
Comment on lines
+379
to
+397
| -d) log_set_priority 10 ;; | ||
| -h | --help | \?) usage "$0" ;; | ||
| -x) set -x ;; | ||
| --) | ||
| SEPARATOR_FOUND=1 | ||
| shift | ||
| break | ||
| ;; | ||
| -*) | ||
| usage "$0" | ||
| ;; | ||
| *) | ||
| if [ $SEPARATOR_FOUND -eq 0 ]; then | ||
| # First non-flag argument is the tag/version | ||
| TAG="$1" | ||
| else | ||
| TOOL_ARGS="$1 $TOOL_ARGS" | ||
| fi | ||
| ;; |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| -d) log_set_priority 10 ;; | |
| -h | --help | \?) usage "$0" ;; | |
| -x) set -x ;; | |
| --) | |
| SEPARATOR_FOUND=1 | |
| shift | |
| break | |
| ;; | |
| -*) | |
| usage "$0" | |
| ;; | |
| *) | |
| if [ $SEPARATOR_FOUND -eq 0 ]; then | |
| # First non-flag argument is the tag/version | |
| TAG="$1" | |
| else | |
| TOOL_ARGS="$1 $TOOL_ARGS" | |
| fi | |
| ;; | |
| -d) log_set_priority 10 ;; | |
| -h | --help | \?) usage "$0" ;; | |
| -x) set -x ;; | |
| --) | |
| SEPARATOR_FOUND=1 | |
| shift | |
| break | |
| ;; | |
| -*) | |
| usage "$0" | |
| ;; | |
| *) | |
| if [ $SEPARATOR_FOUND -eq 0 ]; then | |
| # First non-flag argument is the tag/version | |
| TAG="$1" | |
| else | |
| TOOL_ARGS="$1 $TOOL_ARGS" | |
| fi | |
| ;; |
| log_info "Resolved version: ${VERSION} (tag: ${TAG})" | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
Comment on lines
+443
to
+444
| if [ "${UNAME_ARCH}" = 'amd64' ] && true | ||
| then |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| if [ "${UNAME_ARCH}" = 'amd64' ] && true | |
| then | |
| if [ "${UNAME_ARCH}" = 'amd64' ] && true; then |
Comment on lines
+447
to
+448
| if [ "${UNAME_ARCH}" = '386' ] && true | ||
| then |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| if [ "${UNAME_ARCH}" = '386' ] && true | |
| then | |
| if [ "${UNAME_ARCH}" = '386' ] && true; then |
Comment on lines
+451
to
+452
| if [ "${UNAME_OS}" = 'windows' ] && true | ||
| then |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| if [ "${UNAME_OS}" = 'windows' ] && true | |
| then | |
| if [ "${UNAME_OS}" = 'windows' ] && true; then |
Contributor
|
🏷️ [bumpr] Next version:v1.4.0 Changes:v1.3.2...reviewdog:update-installer-script |
Contributor
|
🚀 [bumpr] Bumped! New version:v1.4.0 Changes:v1.3.2...v1.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.