Merged
Conversation
This makes the following changes to the AWS SigV4 signing functionality: 1. Sign all request headers instead of just Content-Type. 2. Allow specifying a service name.
|
Any chance we could get this merged? If there's other work necessary, I'd be happy to pick it up. |
sabaoongfx
pushed a commit
to sabaoongfx/request-modern
that referenced
this pull request
Mar 10, 2026
This makes the following changes to the AWS SigV4 signing functionality: 1. Sign all request headers instead of just Content-Type. 2. Allow specifying a service name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
npm testlocally and all tests are passing.PR Description
This makes the following changes to the AWS SigV4 signing functionality:
Content-Type.