Skip to content

Use sudo to clear cache source during extraction#37

Merged
AkihiroSuda merged 2 commits intoreproducible-containers:mainfrom
enam-co:main
Jun 30, 2024
Merged

Use sudo to clear cache source during extraction#37
AkihiroSuda merged 2 commits intoreproducible-containers:mainfrom
enam-co:main

Conversation

@rose-m
Copy link
Copy Markdown
Contributor

@rose-m rose-m commented Jun 26, 2024

Thank you for the maintained fork first of all!

This should hopefully fix #31 which I also encountered.

rose-m added 2 commits June 26, 2024 12:26
Not using sudo sometimes could lead to an EACCESS issue depending on
what was actually cached.

Signed-off-by: Michael Rose <michael@enam.co>
Signed-off-by: Michael Rose <michael@enam.co>
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment thread .editorconfig
@@ -0,0 +1,3 @@
[*.ts]
indent_style = space
indent_size = 4
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of change should be another PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry for that. I had to add it as otherwise auto-formatting would always start changing the indent.

@AkihiroSuda AkihiroSuda merged commit 5b6db76 into reproducible-containers:main Jun 30, 2024
github-actions Bot pushed a commit to starkayc/patchy that referenced this pull request Mar 12, 2026
…it-cache-dance action to v3.2.0 (#23)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [https://github.com/reproducible-containers/buildkit-cache-dance](https://github.com/reproducible-containers/buildkit-cache-dance) | action | minor | `v3.1.0` -> `v3.2.0` |

---

### Release Notes

<details>
<summary>reproducible-containers/buildkit-cache-dance (https://github.com/reproducible-containers/buildkit-cache-dance)</summary>

### [`v3.2.0`](https://github.com/reproducible-containers/buildkit-cache-dance/releases/tag/v3.2.0)

[Compare Source](reproducible-containers/buildkit-cache-dance@v3.1.2...v3.2.0)

#### What's Changed

-   Allow overriding container image by [@&#8203;relu](https://github.com/relu) in reproducible-containers/buildkit-cache-dance#44
-   Added support for running with different builder by [@&#8203;ty2](https://github.com/ty2) in reproducible-containers/buildkit-cache-dance#45
-   Determine default cache map from Dockerfile by [@&#8203;bennesp](https://github.com/bennesp) in reproducible-containers/buildkit-cache-dance#49

#### New Contributors

-   [@&#8203;relu](https://github.com/relu) made their first contribution in reproducible-containers/buildkit-cache-dance#44
-   [@&#8203;ty2](https://github.com/ty2) made their first contribution in reproducible-containers/buildkit-cache-dance#45
-   [@&#8203;bennesp](https://github.com/bennesp) made their first contribution in reproducible-containers/buildkit-cache-dance#49

**Full Changelog**: reproducible-containers/buildkit-cache-dance@v3.1.2...v3.2.0

### [`v3.1.2`](https://github.com/reproducible-containers/buildkit-cache-dance/releases/tag/v3.1.2)

[Compare Source](reproducible-containers/buildkit-cache-dance@v3.1.1...v3.1.2)

#### What's Changed

-   Fix not preserving uid and/or gid by [@&#8203;mabrikan](https://github.com/mabrikan) in reproducible-containers/buildkit-cache-dance#35
-   Use sudo to clear cache source during extraction by [@&#8203;rose-m](https://github.com/rose-m) in reproducible-containers/buildkit-cache-dance#37

#### New Contributors

-   [@&#8203;mabrikan](https://github.com/mabrikan) made their first contribution in reproducible-containers/buildkit-cache-dance#35
-   [@&#8203;rose-m](https://github.com/rose-m) made their first contribution in reproducible-containers/buildkit-cache-dance#37

**Full Changelog**: reproducible-containers/buildkit-cache-dance@v3.1.1...v3.1.2

### [`v3.1.1`](https://github.com/reproducible-containers/buildkit-cache-dance/releases/tag/v3.1.1)

[Compare Source](reproducible-containers/buildkit-cache-dance@v3.1.0...v3.1.1)

#### What's Changed

-   Ensure scratch directory exists when calling extractCache by [@&#8203;Chagui-](https://github.com/Chagui-) in reproducible-containers/buildkit-cache-dance#29
-   Do not extract cache on job failure by [@&#8203;borchero](https://github.com/borchero) in reproducible-containers/buildkit-cache-dance#32

#### New Contributors

-   [@&#8203;Chagui-](https://github.com/Chagui-) made their first contribution in reproducible-containers/buildkit-cache-dance#29
-   [@&#8203;borchero](https://github.com/borchero) made their first contribution in reproducible-containers/buildkit-cache-dance#32

**Full Changelog**: reproducible-containers/buildkit-cache-dance@v3.1.0...v3.1.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4yOS4xIiwidXBkYXRlZEluVmVyIjoiNDAuMjkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Reviewed-on: https://git.nadeko.net/Fijxu/file-uploader-crystal/pulls/23
Co-authored-by: Renovate Bot <git@nadeko.net>
Co-committed-by: Renovate Bot <git@nadeko.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Err: cleaning cache source directory: Error: EACCES: permission denied

3 participants