Allow replica to master promotion in nodes_cache#2549
Merged
dvora-h merged 1 commit intoredis:masterfrom Jan 11, 2023
Merged
Conversation
bf2a30c to
af47499
Compare
Codecov ReportBase: 92.24% // Head: 92.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
- Coverage 92.24% 92.22% -0.02%
==========================================
Files 115 115
Lines 29554 29581 +27
==========================================
+ Hits 27262 27281 +19
- Misses 2292 2300 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dvora-h
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.
fixes #2433
When replica is promoted to master, ClusterNode's server_type must change accordingly, but the current implementation reuses the server_type, so no master is found in nodes_cache after initialization
This PR changes the server_type to a correct value, even if we reuse ClusterNode from nodes_cache
I've personally experienced this scenario, when i changed instance type in AWS Elasticache