Repository navigation
Cluster primary node map is not refreshed on slot renewal, so primary-only commands go to demoted nodes after failover - #4692
Merged
Conversation
ggivo
added a commit
that referenced
this pull request
Aug 21, 2026
ggivo
added a commit
that referenced
this pull request
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JedisClusterInfoCacheTest, failover replayed throughrenewClusterSlotsinstead ofdiscoverClusterNodesAndSlots:And against the
cluster-stabledocker env afterCLUSTER FAILOVERon :7483:primaryNodesCacheis only written bydiscoverClusterNodesAndSlots, which runs once at construction. Every later refresh (MOVED handling, the topology-refresh timer,refreshClusterTopology()) goes throughdiscoverClusterSlots, which rebuilds slots and prunes dead nodes but leaves the primary map as it was, soALL_SHARDSbroadcasts, keyless writes andgetConnection()keep targeting the pre-failover primaries. Rebuild the map in the same write-locked block, as the initial discovery already does. With the change the run above ends in[localhost:7480, localhost:7481, localhost:7483]andFLUSHALL -> OK.Fixes #4691.
Note
Cursor Bugbot is generating a summary for commit 36ed766. Configure here.